tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyunsik Choi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-711) Add Avro storage support
Date Tue, 15 Apr 2014 11:58:21 GMT

    [ https://issues.apache.org/jira/browse/TAJO-711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13969465#comment-13969465
] 

Hyunsik Choi commented on TAJO-711:
-----------------------------------

Above all, thank you for nice contribution!

The further process might continue even though the initial java compilation was failed due
to the license check of rat check. So, the following tests might use the existing JAR files
instead of the patched ones. This causes the pre-commit test failure. I'll fix the precommit
test script bug to be stopped at the failure of rat. 

Also, as [~jhkim] mentioned, I suggest you to add one exclude rule to {{${TAJO_HOME}/pom.xml}}.
I think that the exclusion of *.avsc is better because *.schema files are used for another
purpose. It will fix the current problem.

{noformat}
  <exclude>**/*.avsc</exclude>
{noformat}

With some trivial fix of pom.xml, I already tested your patch. All unit tests are passed successfully.
I'm reviewing your patch. I'll comment soon!

> Add Avro storage support
> ------------------------
>
>                 Key: TAJO-711
>                 URL: https://issues.apache.org/jira/browse/TAJO-711
>             Project: Tajo
>          Issue Type: New Feature
>            Reporter: David Chen
>            Assignee: David Chen
>         Attachments: TAJO-711.patch, TAJO-711.patch, TAJO-711_20140413_20:36:40.patch,
TAJO-711_20140413_21:00:34.patch, TAJO-711_20140413_21:46:27.patch, TAJO-711_20140414_11:07:13.patch
>
>
> Add {{FileScanner}} and {{FileAppender}} for reading from and writing to Avro.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message