tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tajo QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-709) Add .reviewboardrc and use rbt instead of post-review
Date Wed, 02 Apr 2014 17:49:25 GMT

    [ https://issues.apache.org/jira/browse/TAJO-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957940#comment-13957940
] 

Tajo QA commented on TAJO-709:
------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12638297/TAJO-709_20140402_10%3A39%3A48.patch
  against master revision dc40d84.

    {color:green}+1 @author.{color}  The patch does not contain any @author tags.

    {color:red}-1 tests included.{color}  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac.{color}  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the total number
of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:green}+1 findbugs.{color}  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/303//testReport/
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/303//console

This message is automatically generated.

> Add .reviewboardrc and use rbt instead of post-review
> -----------------------------------------------------
>
>                 Key: TAJO-709
>                 URL: https://issues.apache.org/jira/browse/TAJO-709
>             Project: Tajo
>          Issue Type: Improvement
>          Components: conf and scripts
>            Reporter: David Chen
>            Assignee: David Chen
>            Priority: Minor
>         Attachments: TAJO-709.patch, TAJO-709_20140402_10:39:48.patch
>
>
> The {{request-patch-review.py}} script uses the {{post-review}} tool to post a patch
to Review Board, which is deprecated in favor of {{rbt}}. The instructions on setting up configuration
for submitting posts is also slightly complex and can be made simpler by adding a {{.reviewboardrc}}
to source control.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message