tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-709) Add .reviewboardrc and use rbt instead of post-review
Date Tue, 01 Apr 2014 02:16:15 GMT

    [ https://issues.apache.org/jira/browse/TAJO-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13956021#comment-13956021
] 

David Chen commented on TAJO-709:
---------------------------------

I think this is ready for a preliminary review. The main changes are:

 * Some style cleanup for readability.
 * Break up the large main() into multiple smaller functions to make the logic of the script
more clear.
 * Add .reviewboardrc and use rbt instead of post-review, which is deprecated
 * Read tracking branch from .reviewboardrc and make -b --branch optional and used only if
the user wishes to specify a different tracking branch than the default.

The file now appears longer but not because there is logic but rather because most lines are
now under 80 characters in length.

Posting a review is now as easy as: {{./request-patch-review.py -j TAJO-709}} since the default
branch (origin/master) is read from .reviewboardrc.

Possible additional considerations:
 * I am getting a Internal Server Error 500 when running the script with {{-pa}} when the
script calls {{jira.transition_issue}}. I do not think this is caused by my changes because
I got the same error when running the original script without my changes.
 * I don't completely like the way I am passing so many parameters around. This can be made
cleaner using a class but that might be overengineering.

> Add .reviewboardrc and use rbt instead of post-review
> -----------------------------------------------------
>
>                 Key: TAJO-709
>                 URL: https://issues.apache.org/jira/browse/TAJO-709
>             Project: Tajo
>          Issue Type: Improvement
>          Components: conf and scripts
>            Reporter: David Chen
>            Assignee: David Chen
>            Priority: Minor
>         Attachments: TAJO-709.patch
>
>
> The {{request-patch-review.py}} script uses the {{post-review}} tool to post a patch
to Review Board, which is deprecated in favor of {{rbt}}. The instructions on setting up configuration
for submitting posts is also slightly complex and can be made simpler by adding a {{.reviewboardrc}}
to source control.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message