tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Chen" <dc...@linkedin.com>
Subject Re: Review Request 20060: TAJO-736: Add table management documentation
Date Sun, 06 Apr 2014 00:16:03 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20060/#review39641
-----------------------------------------------------------



tajo-docs/src/main/sphinx/table_management/parquet.rst
<https://reviews.apache.org/r/20060/#comment72175>

    Add a "the" before ``CREATE TABLE`` and before "Data Definition Language".



tajo-docs/src/main/sphinx/table_management/parquet.rst
<https://reviews.apache.org/r/20060/#comment72176>

    Add a "your" before ``CREATE TABLE``.



tajo-docs/src/main/sphinx/table_management/parquet.rst
<https://reviews.apache.org/r/20060/#comment72177>

    Remove "The" before "below".



tajo-docs/src/main/sphinx/table_management/parquet.rst
<https://reviews.apache.org/r/20060/#comment72178>

    "As a result, Tajo's Parquet storage type does not support nested schemas."



tajo-docs/src/main/sphinx/table_management/parquet.rst
<https://reviews.apache.org/r/20060/#comment72179>

    "However, we are currently working on adding support for nested schemas and non-scalar
types."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72184>

    The 'i' should be lower case.



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72180>

    I don't think RCFile should be plural.
    
    "...shares many similarities..."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72181>

    Add "the" before ``CREATE TABLE`` and before "Data Definition Language."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72182>

    Add a "your" before ``CREATE TABLE``.



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72183>

    RCFile



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72185>

    "...the RCFile storage type..."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72186>

    "...is the default (de)serializer class."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72187>

    "The compression algorithm used to compress files. The compression codec name should be
the fully qualified class name..."
    
    "By default, ..."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72188>

    "...is an example for creating a table using RCFile that uses compression."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72190>

    "stores column values in a binary file format."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72191>

    The RCFile format can store some metadata in the RCFile header."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72192>

    "... is the default..."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72193>

    "Regardless of whether the RCFiles are written by Apache..., the files are compatible..."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72194>

    ...Tajo can process RCFiles written by Apache Hive and vice versa."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72195>

    "...RCFiles written by Hive, we need to manually specify the (de)serializer class name..."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72196>

    "...in Tajo."
    
    FYI, I think Hive uses the term "SerDe" instead of "(de)serializer." Perhaps we should
use "SerDe" when referring to the Hive class but stay with "(de)serializer" when referring
to the Tajo class?



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72197>

    "...when a user creates an external table pointing to data of an existing table."
    
    I understand what you're trying to say here. It's not an easy sentence to make clear.
:)



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72198>

    Remove "will".
    
    I think it is better to use "written by" rather than "generated in."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72199>

    "...set the physical property..."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72200>

    "...set the physical property..."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72201>

    "...the default..."



tajo-docs/src/main/sphinx/table_management/rcfile.rst
<https://reviews.apache.org/r/20060/#comment72202>

    "...you can omit the ``rcfile.serde```..."


- David Chen


On April 5, 2014, 5:28 p.m., Hyunsik Choi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20060/
> -----------------------------------------------------------
> 
> (Updated April 5, 2014, 5:28 p.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-736
>     https://issues.apache.org/jira/browse/TAJO-736
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> Jinho and I wrote some user documentations for file formats. This patch contains documentations
for CSV file, RCFile, and Parquet file.
> 
> 
> Diffs
> -----
> 
>   tajo-docs/src/main/sphinx/partitioning/column_partitioning.rst e88d23ff110e0326a667b51c45d5897d37eb04bc

>   tajo-docs/src/main/sphinx/partitioning/intro_to_partitioning.rst bfb555f6a49b91adf89f7c7a94ad9226d641e0d0

>   tajo-docs/src/main/sphinx/table_management/csv.rst c11a34315196c276c35ae5eb94c2b66653383b8a

>   tajo-docs/src/main/sphinx/table_management/parquet.rst a994b7e4008017d45622c845a19f2884ed15bc8f

>   tajo-docs/src/main/sphinx/table_management/rcfile.rst 21f825313a84cffa95e615206108f455817836e8

> 
> Diff: https://reviews.apache.org/r/20060/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hyunsik Choi
> 
>


Mime
View raw message