tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Chen" <dc...@linkedin.com>
Subject Re: Review Request 20060: TAJO-736: Add table management documentation
Date Sat, 05 Apr 2014 23:55:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20060/#review39636
-----------------------------------------------------------



tajo-docs/src/main/sphinx/partitioning/column_partitioning.rst
<https://reviews.apache.org/r/20060/#comment72121>

    Add a "the" after the "using" and the "use."



tajo-docs/src/main/sphinx/partitioning/column_partitioning.rst
<https://reviews.apache.org/r/20060/#comment72123>

    "as the partition keys"?



tajo-docs/src/main/sphinx/partitioning/column_partitioning.rst
<https://reviews.apache.org/r/20060/#comment72124>

    Add a "the" between "in" and ``WHERE``.



tajo-docs/src/main/sphinx/partitioning/column_partitioning.rst
<https://reviews.apache.org/r/20060/#comment72126>

    "...Tajo can process the Hive partitioned tables directly."



tajo-docs/src/main/sphinx/partitioning/column_partitioning.rst
<https://reviews.apache.org/r/20060/#comment72127>

    "There are currently no known compatibility issues."



tajo-docs/src/main/sphinx/partitioning/intro_to_partitioning.rst
<https://reviews.apache.org/r/20060/#comment72129>

    "easy table management"



tajo-docs/src/main/sphinx/partitioning/intro_to_partitioning.rst
<https://reviews.apache.org/r/20060/#comment72130>

    "Currently, Apache Tajo only provides Apache Hive-compatible column partitioning."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72131>

    "...broken by a line feed character"



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72132>

    "is the default delimiter"



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72150>

    "...used as the default field delimiter..."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72151>

    Add a "the" before ``CREATE TABLE`` and "Data Definition Language"



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72152>

    Add a "your" before ``CREATE TABLE``.



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72153>

    CSV should be all caps.



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72154>

    "...the CSV storage format..."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72155>

    Add a "the" before "default field delimiter."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72157>

    "The compression algorithm used to compress files. The compression codec name should be
the fully qualified class name..."
    
    "By default, compression is disabled."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72158>

    "...is the default (de)serializer class."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72160>

    "The following example..."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72161>

    "Be careful when using ``\n`` as the field delimiter because CSV uses ``\n`` as the line
delimiter."
    
    Just wondering: does the CSV format disallow using the same delimiter character for fields
and lines?



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72162>

    "...Tajo does not provide a way..."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72165>

    "The CSV storage format not only provides reading and writing interfaces for CSV data
but also allows users to process custom..."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72166>

    "...with custom (de)serializers, Tajo can process JSON file formats or any specialized..."
    
    Note: better to use active voice than passive voice when possible. :)



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72167>

    "custom"
    
    Also, the "please" is not necessary.



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72168>

    fully qualified



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72169>

    "For example:" should be sufficient. This can be in the same paragraph as the previous.



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72170>

    "...in CSV files...is an empty string..."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72171>

    "...a NULL value..."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72172>

    "You can also use your own NULL character..."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72173>

    Remove "some".
    
    "...the CSV tables cannot be directly used in Hive."



tajo-docs/src/main/sphinx/table_management/csv.rst
<https://reviews.apache.org/r/20060/#comment72174>

    "...there is not way to specify..."


- David Chen


On April 5, 2014, 5:28 p.m., Hyunsik Choi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20060/
> -----------------------------------------------------------
> 
> (Updated April 5, 2014, 5:28 p.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-736
>     https://issues.apache.org/jira/browse/TAJO-736
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> Jinho and I wrote some user documentations for file formats. This patch contains documentations
for CSV file, RCFile, and Parquet file.
> 
> 
> Diffs
> -----
> 
>   tajo-docs/src/main/sphinx/partitioning/column_partitioning.rst e88d23ff110e0326a667b51c45d5897d37eb04bc

>   tajo-docs/src/main/sphinx/partitioning/intro_to_partitioning.rst bfb555f6a49b91adf89f7c7a94ad9226d641e0d0

>   tajo-docs/src/main/sphinx/table_management/csv.rst c11a34315196c276c35ae5eb94c2b66653383b8a

>   tajo-docs/src/main/sphinx/table_management/parquet.rst a994b7e4008017d45622c845a19f2884ed15bc8f

>   tajo-docs/src/main/sphinx/table_management/rcfile.rst 21f825313a84cffa95e615206108f455817836e8

> 
> Diff: https://reviews.apache.org/r/20060/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Hyunsik Choi
> 
>


Mime
View raw message