tajo-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jinho Kim" <jh...@apache.org>
Subject Re: Review Request 19406: TAJO-616: SequenceFile support
Date Tue, 01 Apr 2014 07:36:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19406/#review39135
-----------------------------------------------------------

Ship it!


+1 
Looks great for me.  I've verified 'MysqlCatalogStore, HcatalogStore, TPCH-1'.
Thank you!!

- Jinho Kim


On April 1, 2014, 7:03 a.m., Jung JaeHwa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19406/
> -----------------------------------------------------------
> 
> (Updated April 1, 2014, 7:03 a.m.)
> 
> 
> Review request for Tajo.
> 
> 
> Bugs: TAJO-616
>     https://issues.apache.org/jira/browse/TAJO-616
> 
> 
> Repository: tajo
> 
> 
> Description
> -------
> 
> Hadoop users can create a sequence file format, and hive users also can create a table
which was stored as SequenceFIle. So, we need to support sequence file format as follows:
> 
> * Update parser and catalog for SequenceFile
> * Make serializer/deserializer configurable in SequenceFile
> * Scanner for SequenceFile
> * Support for compression/decompression of SequenceFile
> * Compatible to apache hive
> 
> 
> Diffs
> -----
> 
>   tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogConstants.java
c7116f6 
>   tajo-catalog/tajo-catalog-common/src/main/java/org/apache/tajo/catalog/CatalogUtil.java
22f54ca 
>   tajo-catalog/tajo-catalog-common/src/main/proto/CatalogProtos.proto d3abc70 
>   tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogStore.java
a4bdb28 
>   tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/main/java/org/apache/tajo/catalog/store/HCatalogUtil.java
d426369 
>   tajo-catalog/tajo-catalog-drivers/tajo-hcatalog/src/test/java/org/apache/tajo/catalog/store/TestHCatalogStore.java
b9a734e 
>   tajo-common/src/main/java/org/apache/tajo/util/Bytes.java f9ba923 
>   tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/benchmark/TPCH.java 20015b5

>   tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/TpchTestBase.java 0b80231

>   tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/client/TestDDLBuilder.java
73f7d5e 
>   tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestCTASQuery.java
72e92d2 
>   tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestNullValues.java
1f1d9e1 
>   tajo-docs/src/main/sphinx/table_management/csv.rst PRE-CREATION 
>   tajo-docs/src/main/sphinx/table_management/file_formats.rst 26edac4 
>   tajo-docs/src/main/sphinx/table_management/parquet.rst PRE-CREATION 
>   tajo-docs/src/main/sphinx/table_management/rcfile.rst PRE-CREATION 
>   tajo-docs/src/main/sphinx/table_management/sequencefile.rst PRE-CREATION 
>   tajo-storage/pom.xml 9f144bb 
>   tajo-storage/src/main/java/org/apache/tajo/storage/CSVFile.java 116e25c 
>   tajo-storage/src/main/java/org/apache/tajo/storage/parquet/TajoRecordMaterializer.java
cce7ead 
>   tajo-storage/src/main/java/org/apache/tajo/storage/rcfile/RCFile.java 2fd3455 
>   tajo-storage/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileAppender.java
PRE-CREATION 
>   tajo-storage/src/main/java/org/apache/tajo/storage/sequencefile/SequenceFileScanner.java
PRE-CREATION 
>   tajo-storage/src/main/java/org/apache/tajo/storage/trevni/TrevniScanner.java ed71730

>   tajo-storage/src/main/java/org/apache/tajo/storage/v2/CSVFileScanner.java 79ddfdd 
>   tajo-storage/src/main/resources/storage-default.xml e3a0eaf 
>   tajo-storage/src/test/java/org/apache/tajo/storage/TestCompressionStorages.java a776eb6

>   tajo-storage/src/test/java/org/apache/tajo/storage/TestMergeScanner.java ad12c06 
>   tajo-storage/src/test/java/org/apache/tajo/storage/TestStorages.java b5338ff 
>   tajo-storage/src/test/resources/storage-default.xml 75274d0 
> 
> Diff: https://reviews.apache.org/r/19406/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install -Phcatalog-0.12.0
> mvn clean install -Phcatalog-0.12.0 -Dtajo.catalog.store.class=org.apache.tajo.catalog.store.HCatalogStore
> 
> 
> Thanks,
> 
> Jung JaeHwa
> 
>


Mime
View raw message