tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eli Reisman <apache.mail...@gmail.com>
Subject Re: [DISCUSS] We need to suppress a huge patch without any proposal or discussion.
Date Thu, 08 Jan 2015 08:21:57 GMT
Totally agree, more eyes on a patch is always a good thing! +1

On Sun, Dec 21, 2014 at 12:17 AM, Jihun Kang <ykrips@gmail.com> wrote:

> I agree with you, and sizing the issue is definitely important for us. I
> feel that we can create some epic issues with related child sub-tasks when
> we add some functions on planning phase or during the iteration. If most of
> Tajo developers agree with this issue, we can continue to discuss the size
> factor of issue. I would vote +1 to define a process of gathering proposals
> on a new feature.
>
> 2014-12-21 15:31 GMT+09:00 Hyunsik Choi <hyunsik@apache.org>:
>
> > I agree that we need to proceed some work with small tasks.
> >
> > -hyunsik
> >
> > On Sunday, December 21, 2014, Jihoon Son <jihoonson@apache.org> wrote:
> >
> > > +1
> > > I totally agree with you.
> > > I also suffered the same problem. The huge patch makes the code review
> > > difficult, and thus the review process might be delayed.
> > >
> > > We should partition a large issue into several smaller sub tasks.
> > > I also know that this part is not easy, but we need to try by making a
> > > detailed proposal.
> > >
> > > Sincerely,
> > > Jihoon
> > >
> > > 2014-12-21 14:18 GMT+09:00 Hyunsik Choi <hyunsik@apache.org
> > <javascript:;>
> > > >:
> > >
> > > > Hi folks,
> > > >
> > > > I happy to see that Tajo community is going well and is getting
> > healthy.
> > > >
> > > > For the sake of more healthy community and contribution, I propose
> > > > that we suppress a huge patch without any proposal and enough
> > > > discussion.
> > > >
> > > > We sometimes can see huge patch contributions without any proposal
> and
> > > > discussion. Honestly, I did too. In such cases, it is very hard to
> > > > give any guidance about the direction because patches already proceed
> > > > too far from starting point. As a result, reviewers feel lots of
> > > > burden to give comments. Also, contributors also need to do
> > > > unnecessary works if reviews give comments.
> > > >
> > > > In detail, we need to submit some detailed proposal if necessary.
> > > > Also, any guy need to ask some proposal if necessary. Actually, we
> > > > have done so far. But, we need to be eager to do so.
> > > >
> > > > How do you think about it?
> > > >
> > > > Best regards,
> > > > Hyunsik
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message