Mailing-List: contact dev-help@tajo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tajo.apache.org
MIME-Version: 1.0
In-Reply-To: 
 <CAM=XDd8v9q9Qwukje2qqV6TTuHQiLTmqzeH7V2LTGZh+Mzby=Q@mail.gmail.com>
References: 
 <CAM=XDd8v9q9Qwukje2qqV6TTuHQiLTmqzeH7V2LTGZh+Mzby=Q@mail.gmail.com>
Date: Sun, 21 Dec 2014 14:40:29 +0900
Message-ID: 
 <CACZfFK5zzxg6EsdY5aHRC3VXDinC8y9V_wLbxd8-MMzNWfvrrA@mail.gmail.com>
Subject: Re: [DISCUSS] We need to suppress a huge patch without any proposal
 or discussion.
From: Jihoon Son <jihoonson@apache.org>
To: "dev@tajo.apache.org" <dev@tajo.apache.org>
Content-Type: multipart/alternative; boundary=001a1140f54e36835a050ab36186

--001a1140f54e36835a050ab36186
Content-Type: text/plain; charset=UTF-8

+1
I totally agree with you.
I also suffered the same problem. The huge patch makes the code review
difficult, and thus the review process might be delayed.

We should partition a large issue into several smaller sub tasks.
I also know that this part is not easy, but we need to try by making a
detailed proposal.

Sincerely,
Jihoon

2014-12-21 14:18 GMT+09:00 Hyunsik Choi <hyunsik@apache.org>:

> Hi folks,
>
> I happy to see that Tajo community is going well and is getting healthy.
>
> For the sake of more healthy community and contribution, I propose
> that we suppress a huge patch without any proposal and enough
> discussion.
>
> We sometimes can see huge patch contributions without any proposal and
> discussion. Honestly, I did too. In such cases, it is very hard to
> give any guidance about the direction because patches already proceed
> too far from starting point. As a result, reviewers feel lots of
> burden to give comments. Also, contributors also need to do
> unnecessary works if reviews give comments.
>
> In detail, we need to submit some detailed proposal if necessary.
> Also, any guy need to ask some proposal if necessary. Actually, we
> have done so far. But, we need to be eager to do so.
>
> How do you think about it?
>
> Best regards,
> Hyunsik
>

--001a1140f54e36835a050ab36186--