Return-Path: X-Original-To: apmail-tajo-dev-archive@minotaur.apache.org Delivered-To: apmail-tajo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9C6BC17832 for ; Fri, 7 Nov 2014 08:25:14 +0000 (UTC) Received: (qmail 63017 invoked by uid 500); 7 Nov 2014 08:25:14 -0000 Delivered-To: apmail-tajo-dev-archive@tajo.apache.org Received: (qmail 62973 invoked by uid 500); 7 Nov 2014 08:25:14 -0000 Mailing-List: contact dev-help@tajo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tajo.apache.org Delivered-To: mailing list dev@tajo.apache.org Received: (qmail 62950 invoked by uid 99); 7 Nov 2014 08:25:14 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2014 08:25:14 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of eminency@gmail.com designates 209.85.192.169 as permitted sender) Received: from [209.85.192.169] (HELO mail-pd0-f169.google.com) (209.85.192.169) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Nov 2014 08:24:45 +0000 Received: by mail-pd0-f169.google.com with SMTP id y10so2893007pdj.28 for ; Fri, 07 Nov 2014 00:23:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=I+Mp01cdtmqL0BOrD2Du71HaWzw/2Oquj4YKhZwWSXI=; b=C65buMe0C3b2DsnVlOkQ1ZpKDfDXYTfwwC+L1sPXPHclXoh4Fu41lppJY5Zd95ywmn lNkuhm2my15Xj16MWEUpFkM9hZWDJ0qacAdOaiQnFJsWZ3RR7tee1xEVtqNX27sSwj9F cg54p18Bfe7yMMkGGi0iCbzWprxW7iAuZewXudOffHsSIlZQW/bnvL0aL8BAXJ0R+vkB OnHc5ZJsg2LXIXX9E1IV1aQfEh+Af7rLky2SfCCGUUW8h9r3BkxGLElzcStjVRT62gjZ kzFBxWM+9S1Q3oYlQGN3yoOMY6/0k46sDna9rvji5I5fD/PeJj42wvDkdJF1SlgP8zAU xipw== X-Received: by 10.66.120.202 with SMTP id le10mr10612852pab.86.1415348593909; Fri, 07 Nov 2014 00:23:13 -0800 (PST) Received: from Jongyoungui-MBP.server.gruter.com ([211.63.142.65]) by mx.google.com with ESMTPSA id s6sm4147477pdr.95.2014.11.07.00.23.10 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 07 Nov 2014 00:23:12 -0800 (PST) Message-ID: <545C816A.3060905@gmail.com> Date: Fri, 07 Nov 2014 17:23:06 +0900 From: Jongyoung Park User-Agent: Postbox 3.0.11 (Macintosh/20140602) MIME-Version: 1.0 To: dev@tajo.apache.org Subject: Re: tajoCli history behavior References: In-Reply-To: Content-Type: multipart/alternative; boundary="------------050001010102050906030200" X-Virus-Checked: Checked by ClamAV on apache.org --------------050001010102050906030200 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello Mr. Jung. Firstly, I appreciate your interest in Tajo. I think your contribution could be very helpful and your suggestion sounds like a good feature for UI/UX. Though if you don't request some kind of approval, it is OK. Assign the issue to your account and start, that's it. After you will have done, commiters' opinion will be commented on the issue ticket or Github pull request. If you have another question, feel free to ask and let us know. Thank you for your helping. Regards. Jaewoong Jung wrote: > > Hi all, > > First, a bit of introduction to myself. I'm a software engineer > working at Google and was introduced to Tajo project by my friend, > Keeyong Han, when I was looking for an open-source project to > contribute to. My current role at Google is writing a REST API server > in Java and Android client. But I also have a fair amount of > experience with MapReduce and FlumeJava, so I'm hoping I can be of > help in improving and enhancing the project. > > As a newbie to the open source world and Hadoop, I decided to pick up > the easiest tasks, and this one caught my eye. > > https://issues.apache.org/jira/browse/TAJO-967 > > I took a quick look at the source code, and it looked like a simple > task, indeed. > > However, I also discovered tajoCli's history behavior was slightly > different from others like bash and mysql. > > When the user enters multiple commands in a single line using > semicolon and looks it up using up arrow key later, tajoCli shows each > individual command separately, whereas bash and mysql shows all the > commands in a single line as they were entered. > > For example, if the user enters two commands in a single line like this, > > \version; \d > > tajoCli shows \d first and then \version as the user presses up arrow > key twice. But, bash and mysql show \version; \d together again with a > single up action. > > I don't think bash and mysql's history behavior is necessarily better > than tajoCli or vice verssa, but, IMHO, it'd be better if tajo > provides user experience that users are used to and naturally expect. > > WDYT? If you agree, I can make the change myself. > > Thanks, > Jaewoong --------------050001010102050906030200--