tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henry Saputra <hsapu...@apache.org>
Subject Re: Github pull request hooks
Date Sun, 09 Feb 2014 16:44:29 GMT
It works great with Apache Spark. The one thing missing is to enforce
Github pull request to include JIRA in the title to make sure JIRA is
filed.

We could start prototyping it with some JIRAs later once we release 0.8?



On Sun, Feb 9, 2014 at 5:01 AM, Hyunsik Choi <hyunsik@apache.org> wrote:
> FYI, GIthub pull request seems to be interested with mailing list.
>
>
> ---------- Forwarded message ----------
> From: Matei Zaharia <matei.zaharia@gmail.com>
> Date: Sun, Feb 9, 2014 at 7:42 AM
> Subject: Re: Github pull request hooks
> To: general@incubator.apache.org
>
>
> Thanks for the very quick action on this, Daniel and Jake!
>
> Matei
>
> On Feb 8, 2014, at 3:51 AM, Daniel Gruno <rumble@cord.dk> wrote:
>
>> Let me just get some information across to podlings wondering about this
>> new GitHub stuff we've added, and what is supported so far:
>>
>> - It is now possible to relay new GitHub PRs, comments on PRs and
>> closing/reopening of PRs to your mailing list.
>>
>> - It is also possible for all committers in a project to close PRs with
>> a commit message to the master/trunk branch of a project saying, for
>> instance, "this closes #1234 on GitHub" in the commit message.
>>
>> - This GitHub feature is currently only supported for projects/podlings
>> that have their primary source repository in Git. If you have an SVN
>> mirror instead, we are not fully able to support GitHub PR relaying at
>> the time being, but will support it in the near future.
>>
>> - You have to request PR comments to be enabled for your project,
>> preferably via a JIRA ticket (at
>> https://issues.apache.org/jira/browse/INFRA ). By default, hooks have
>> been set up so that only PR opening/closing gets passed on. New setups
>> will include relaying of comments, but if your project has been set up
>> for a web hook in the past, you must request it be set up with comment
>> notification. This is a new default setting, and all projects that now
>> request PR notifications will automatically receive comments on PRs in
>> their respective mailing list as well. If you are unsure whether your
>> project is set up for relaying GitHub messages (and you want this), make
>> a new JIRA ticket to have it set up, rather one ticket too many than one
>> too few.
>>
>> - Comments _should_ now be nested, so that each new comment has an email
>> reference to the original PR issue, meaning they will nest in mod_mbox
>> and your email client if you have nesting/threading enabled.
>>
>> - We may, in the future, add the possibility to filter out certain
>> comments from being relayed to the ML (such as jenkins workflows etc),
>> but this will all depend on how this initial phase goes along.
>>
>> With regards,
>> Daniel.
>>
>> On 02/07/2014 10:02 PM, Daniel Gruno wrote:
>>> We had a bit of a snafu on adding PR titles to the subject lines, but
>>> it's been taken care of now.
>>>
>>> With regards,
>>> Daniel.
>>>
>>> On 02/07/2014 09:57 PM, Henry Saputra wrote:
>>>> Ah looks like the missing PR title only happen for the emails
>>>> describing comments from the Github pull requests.
>>>>
>>>> - Henry
>>>>
>>>> On Fri, Feb 7, 2014 at 12:55 PM, Henry Saputra <henry.saputra@gmail.com>
> wrote:
>>>>> Hi Jake,
>>>>>
>>>>> Looks like all the emails from the PR has the same subject:
>>>>> "[GitHub] incubator-spark pull request:"
>>>>>
>>>>> Is there a way to get the Title of the pull request included in the
>>>>> Subject line?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Henry
>>>>>
>>>>> On Fri, Feb 7, 2014 at 8:30 AM, Jake Farrell <jfarrell@apache.org>
> wrote:
>>>>>> I just wanted to follow up on my previous comments about the Github
>>>>>> webhooks not posting comments, Daniel Gruno and I have been debugging
> the
>>>>>> Github webhooks we had in place to send pull request notifications
> and we
>>>>>> have fixed it so comments for issues and pull requests will now go
to
> the
>>>>>> dev@ lists. If anyone replies to this mail it will stay on the dev@list.
>>>>>>
>>>>>> -Jake
>>>>>>
>>>>>>
>>>>>> NOTE: This still remains a project/PMC responsibility to ensure
>>>>>> communication is recorded as this is coming from a 3rd party we do
not
>>>>>> control. Communications should be encouraged to occur on our mailing
> lists.
>>>>>> We (infra) are working to make things easier and allow for better
>>>>>> integrations and are always open to anyone wanting to help contribute
> to
>>>>>> these efforts.
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>>> For additional commands, e-mail: general-help@incubator.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
>> For additional commands, e-mail: general-help@incubator.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org

Mime
View raw message