Mailing-List: contact dev-help@tajo.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tajo.incubator.apache.org
Date: Wed, 15 Jan 2014 14:07:20 +0000 (UTC)
From: "Tajo QA (JIRA)" <jira@apache.org>
To: dev@tajo.incubator.apache.org
Message-ID: <JIRA.12687316.1388855958445.6349.1389794840829@arcas>
In-Reply-To: <JIRA.12687316.1388855958445@arcas>
References: <JIRA.12687316.1388855958445@arcas>
Subject: [jira] [Commented] (TAJO-478) Add request-patch-review.py that
 helps submitting patches to jira and reviewboard.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/TAJO-478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872096#comment-13872096 ] 

Tajo QA commented on TAJO-478:
------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12623107/TAJO-478_20140115_19%3A01%3A21.patch
  against master revision 69700bf.

    -1 @author.  The patch appears to contain 6 @author tags which the Tajo community has agreed to not allow in code contributions.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The applied patch does not increase the total number of javadoc warnings.

    +1 checkstyle.  The patch generated 0 code style errors.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/41//testReport/
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/41//console

This message is automatically generated.

> Add request-patch-review.py that helps submitting patches to jira and reviewboard.
> ----------------------------------------------------------------------------------
>
>                 Key: TAJO-478
>                 URL: https://issues.apache.org/jira/browse/TAJO-478
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-478.patch, TAJO-478_20140105_02:22:58.patch, TAJO-478_20140105_02:25:29.patch, TAJO-478_20140109_15:44:43.patch, TAJO-478_20140115_18:48:36.patch, TAJO-478_20140115_19:01:21.patch
>
>
> As we discussed the recent review process, review requests to reviewboard are strongly recommended in Tajo project. 
> http://markmail.org/message/rszy3knctczko23d#query:+page:1+mid:qnozgapggzmwxqrw+state:results
> This patch adds a helper utility to allow users to create a patch against a specified branch, submit the patch to a specified Jira, and create a review request in reviewboard.
> This utility is borrowed from Apache Kafka.
> https://github.com/apache/kafka/blob/trunk/kafka-patch-review.py
> But, I modified some options and add several new features, and this patch includes its documentation.


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)