tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tajo QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-543) InsertNode and CreateTableNode should play their roles
Date Wed, 22 Jan 2014 05:11:27 GMT

    [ https://issues.apache.org/jira/browse/TAJO-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13878267#comment-13878267
] 

Tajo QA commented on TAJO-543:
------------------------------

{color:red}*-1 overall.*{color}  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12624275/TAJO-543.patch
  against master revision 358dbac.

    {color:green}+1 @author.{color}  The patch does not contain any @author tags.

    {color:green}+1 tests included.{color}  The patch appears to include 2 new or modified
test files.

    {color:green}+1 javac.{color}  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc.{color}  The applied patch does not increase the total number
of javadoc warnings.

    {color:green}+1 checkstyle.{color}  The patch generated 0 code style errors.

    {color:red}-1 findbugs.{color}  The patch appears to introduce 158 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit.{color}  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests.{color}  The patch passed unit tests in tajo-core/tajo-core-backend.

Test results: https://builds.apache.org/job/PreCommit-TAJO-Build/72//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-TAJO-Build/72//artifact/incubator-tajo/patchprocess/newPatchFindbugsWarningstajo-core-backend.html
Console output: https://builds.apache.org/job/PreCommit-TAJO-Build/72//console

This message is automatically generated.

> InsertNode and CreateTableNode should play their roles
> ------------------------------------------------------
>
>                 Key: TAJO-543
>                 URL: https://issues.apache.org/jira/browse/TAJO-543
>             Project: Tajo
>          Issue Type: Improvement
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-543.patch
>
>
> Currently, CreateTableNode and InsertNode are just intermediate representations. They
are rewritten to StoreTableNode. But, StoreTableNode does not contain some necessary fields,
such as output table, target table, target columns, overwrite flag and create table flag.
So far, these fields are kept in QueryContext.
> This implementation causes unnecessary and complex rewrite of DistributedQueryHookManager.
As a result, it is hard to maintain and manage CREATE/INSERT plans.
> The main objective of this issue is to improve LogicalPlanner to use CreateTableNode
and InsertNode throughout the planning phase and eliminate complex rewrite in DistributedQueryHookManager.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message