tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyunsik Choi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-495) Implement sha1(text)
Date Sat, 18 Jan 2014 03:33:19 GMT

    [ https://issues.apache.org/jira/browse/TAJO-495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875527#comment-13875527
] 

Hyunsik Choi commented on TAJO-495:
-----------------------------------

+1 for only digest

Both claims are all reasonable. I've considered it in many aspects for a while. Regarding
code maintenance and consistency of user experience, I prefer only digest support. 

Actually, other hashing functions (e.g., md5, sha512) are widely used too. For example, if
we support sha1 and do not support sha512, it may cause inconsistency. It may be confuse for
users.

> Implement sha1(text)
> --------------------
>
>                 Key: TAJO-495
>                 URL: https://issues.apache.org/jira/browse/TAJO-495
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: function/udf
>            Reporter: DaeMyung Kang
>            Assignee: DaeMyung Kang
>            Priority: Minor
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-495.patch
>
>
> sha1('1')    ---> 356a192b7913b04c54574d18c28d46e6395428ab
> sha1('tajo') ---> 02b0e20540b89f0b735092bbac8093eb2e3804cf



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message