tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyunsik Choi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-471) Extract ColumnPartitonUtils class for ColumnPartition rewrite
Date Mon, 06 Jan 2014 12:06:50 GMT

    [ https://issues.apache.org/jira/browse/TAJO-471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13862942#comment-13862942
] 

Hyunsik Choi commented on TAJO-471:
-----------------------------------

Here is my comment. In my opinion, ColumnPartitionUtils will have only few methods. For this
purpose, we have used PlannerUtil which contains a bunch of methods about planning. I think
that PlannerUtil is a nice place for _rewrite_ method. When you move rewrite method, please
rename the method name to a proper name.

> Extract ColumnPartitonUtils class for ColumnPartition rewrite
> -------------------------------------------------------------
>
>                 Key: TAJO-471
>                 URL: https://issues.apache.org/jira/browse/TAJO-471
>             Project: Tajo
>          Issue Type: Improvement
>          Components: physical operator
>            Reporter: DaeMyung Kang
>            Assignee: DaeMyung Kang
>            Priority: Minor
>         Attachments: TAJO-471.patch
>
>
> In ColumnPartitionedTableStoreExec.java and SeqScanExec.java
> They have similar rewriteColumnPartitionedTableSchema function.
> so we extract util class and should use this.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message