Return-Path: X-Original-To: apmail-tajo-dev-archive@minotaur.apache.org Delivered-To: apmail-tajo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BBB2C105DF for ; Mon, 30 Dec 2013 07:05:14 +0000 (UTC) Received: (qmail 95651 invoked by uid 500); 30 Dec 2013 07:05:13 -0000 Delivered-To: apmail-tajo-dev-archive@tajo.apache.org Received: (qmail 95566 invoked by uid 500); 30 Dec 2013 07:05:12 -0000 Mailing-List: contact dev-help@tajo.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tajo.incubator.apache.org Delivered-To: mailing list dev@tajo.incubator.apache.org Received: (qmail 95557 invoked by uid 99); 30 Dec 2013 07:05:12 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Dec 2013 07:05:12 +0000 X-ASF-Spam-Status: No, hits=-2000.4 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 30 Dec 2013 07:05:11 +0000 Received: (qmail 94813 invoked by uid 99); 30 Dec 2013 07:04:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Dec 2013 07:04:50 +0000 Date: Mon, 30 Dec 2013 07:04:50 +0000 (UTC) From: "Jihoon Son (JIRA)" To: dev@tajo.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TAJO-458) Visit methods of LogicalPlanVisitor should take a query block as parameter MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TAJO-458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858617#comment-13858617 ] Jihoon Son commented on TAJO-458: --------------------------------- I leave a comment at the RB. > Visit methods of LogicalPlanVisitor should take a query block as parameter > -------------------------------------------------------------------------- > > Key: TAJO-458 > URL: https://issues.apache.org/jira/browse/TAJO-458 > Project: Tajo > Issue Type: Improvement > Components: planner/optimizer > Reporter: Hyunsik Choi > Assignee: Hyunsik Choi > Fix For: 0.8-incubating > > > A logical plan is composed of multiple query blocks. Each logical node must belong to one query block. A query block instance provides lots of information. So, it is essential information in many rewrite rules and optimizer implementations. > However, so far, individual rewrite rule or optimizer implementation have dealt with query block directly. It may be error-prone and cause duplicated codes. This patch refactors each visitor method of LogicalPlanVisitor to take a query block as a parameter. > I'm expecting that this change will provide more convenience for rewrite rules and optimization development. -- This message was sent by Atlassian JIRA (v6.1.5#6160)