Mailing-List: contact dev-help@tajo.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tajo.incubator.apache.org
Date: Sun, 22 Dec 2013 04:33:50 +0000 (UTC)
From: "Prafulla T (JIRA)" <jira@apache.org>
To: dev@tajo.incubator.apache.org
Message-ID: <JIRA.12668676.1379239996836.723.1387686830069@arcas>
In-Reply-To: <JIRA.12668676.1379239996836@arcas>
References: <JIRA.12668676.1379239996836@arcas>
Subject: [jira] [Commented] (TAJO-182) Comparison of primitive values
 including null value should return NULL.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/TAJO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855096#comment-13855096 ] 

Prafulla T commented on TAJO-182:
---------------------------------

+1 
Changes related to this ticket look good.  I liked how you implemented Three Valued Logic.
I see that patch has fixes for some other tickets as well but does not contain relevant changes to Change.txt


> Comparison of primitive values including null value should return NULL.
> -----------------------------------------------------------------------
>
>                 Key: TAJO-182
>                 URL: https://issues.apache.org/jira/browse/TAJO-182
>             Project: Tajo
>          Issue Type: Bug
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>            Priority: Critical
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-182.patch, TAJO-182_2.patch
>
>
> -If some domain value is compared to Null value, the current implementation will cause InvalidOperationException. Such cases should result in 'false'.-
> If some domain value is compared to Null value, the current implementation will cause either InvalidOperationException or FALSE. Such cases should result in NULL.


--
This message was sent by Atlassian JIRA
(v6.1.5#6160)