Return-Path: X-Original-To: apmail-tajo-dev-archive@minotaur.apache.org Delivered-To: apmail-tajo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 00A17107EA for ; Mon, 23 Dec 2013 05:08:36 +0000 (UTC) Received: (qmail 83913 invoked by uid 500); 23 Dec 2013 05:08:34 -0000 Delivered-To: apmail-tajo-dev-archive@tajo.apache.org Received: (qmail 83828 invoked by uid 500); 23 Dec 2013 05:08:34 -0000 Mailing-List: contact dev-help@tajo.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tajo.incubator.apache.org Delivered-To: mailing list dev@tajo.incubator.apache.org Received: (qmail 83815 invoked by uid 99); 23 Dec 2013 05:08:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Dec 2013 05:08:33 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 23 Dec 2013 05:08:32 +0000 Received: (qmail 77972 invoked by uid 99); 23 Dec 2013 05:07:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Dec 2013 05:07:50 +0000 Date: Mon, 23 Dec 2013 05:07:50 +0000 (UTC) From: "Jinho Kim (JIRA)" To: dev@tajo.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TAJO-182) Correct NULL value handling of primitive operators MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TAJO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13855387#comment-13855387 ] Jinho Kim commented on TAJO-182: -------------------------------- +1 This patch looks great to me. > Correct NULL value handling of primitive operators > -------------------------------------------------- > > Key: TAJO-182 > URL: https://issues.apache.org/jira/browse/TAJO-182 > Project: Tajo > Issue Type: Bug > Components: planner/optimizer > Reporter: Hyunsik Choi > Assignee: Hyunsik Choi > Priority: Critical > Fix For: 0.8-incubating > > Attachments: TAJO-182.patch, TAJO-182_2.patch, TAJO-182_3.patch > > > -If some domain value is compared to Null value, the current implementation will cause InvalidOperationException. Such cases should result in 'false'.- > -If some domain value is compared to Null value, the current implementation will cause either InvalidOperationException or FALSE. Such cases should result in NULL.- > Many primitive operators including arithmetic and comparison do not consider three valued logic. This patch corrects this problem. The original issue title was 'Comparison of primitive values including null value should return NULL.' This issue was expanded for null value handling of all primitive operators. -- This message was sent by Atlassian JIRA (v6.1.5#6160)