tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyunsik Choi (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (TAJO-455) Throw PlanningException when Creating table with Partition exception COLUMN
Date Sun, 29 Dec 2013 10:53:50 GMT

    [ https://issues.apache.org/jira/browse/TAJO-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13858314#comment-13858314
] 

Hyunsik Choi edited comment on TAJO-455 at 12/29/13 10:52 AM:
--------------------------------------------------------------

I like this fix. By the way, wrong format strings are used in this patch.

792 in LogicalPlanner will cause java.util.IllegalFormatConversionException because the format
string is '%d' but PartitionType is an enum type.
357 in GlobalPlanner will be the same to the above.

In addition, 792 and 835 lines width in LogicalPlanner exceed 120 column. Could you reformat
them?

Thanks!


was (Author: hyunsik):
I like this fix. But, wrong format strings are used in this patch.

792 in LogicalPlanner will cause java.util.IllegalFormatConversionException because the format
string is '%d' but PartitionType is an enum type.
357 in GlobalPlanner will be the same to the above.

In addition, 792 and 835 lines width in LogicalPlanner exceed 120 column. Could you reformat
them?

Thanks!

> Throw PlanningException when Creating table with Partition exception COLUMN
> ---------------------------------------------------------------------------
>
>                 Key: TAJO-455
>                 URL: https://issues.apache.org/jira/browse/TAJO-455
>             Project: Tajo
>          Issue Type: Improvement
>          Components: planner/optimizer
>            Reporter: DaeMyung Kang
>            Assignee: DaeMyung Kang
>         Attachments: TAJO-455.patch
>
>
> currently Tajo just support COLUMN Partitoner
> but Tajo accept other Partitioner (HASH, LIST, RANGE)
> so users can create table with unsupported Partitioner.
> but tajo will throws NULL Pointer Exception.
> so. until supporting these Partitioner(HASH, LIST, RANGE)
> I think it is better blcok to create table with Partitioner except COLUMN.
> but, they will be supported soon in future.
> I don't remove codes and tests. 
> and just block them.
> 1. throw exception when creating table with Partitioner except(COLUMN) in logicalPlanner.
> 2. just remove @Test clauese from some test cases.
> 3. add testcase to check failing create table with hash, list, range partitioner
> I might think this patch give more good experience to users.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message