tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-419) Add missing visitor methods of AlgebraVisitor and BaseAlgebraVisitor
Date Mon, 16 Dec 2013 18:05:11 GMT

    [ https://issues.apache.org/jira/browse/TAJO-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849404#comment-13849404
] 

Hudson commented on TAJO-419:
-----------------------------

SUCCESS: Integrated in Tajo-trunk-postcommit #625 (See [https://builds.apache.org/job/Tajo-trunk-postcommit/625/])
TAJO-419: Add missing visitor methods of AlgebraVisitor and BaseAlgebraVisitor. (hyunsik)
(hyunsik: https://git-wip-us.apache.org/repos/asf?p=incubator-tajo.git&a=commit&h=775cfaaad49fee4e79b7cd582b381740461fa6b9)
* tajo-algebra/src/main/java/org/apache/tajo/algebra/OpType.java
* tajo-algebra/src/main/java/org/apache/tajo/algebra/DataType.java
* tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/AlgebraVisitor.java
* tajo-algebra/src/main/java/org/apache/tajo/algebra/Projection.java
* tajo-algebra/src/main/java/org/apache/tajo/algebra/CreateTable.java
* tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BasicLogicalPlanVisitor.java
* tajo-algebra/src/main/java/org/apache/tajo/algebra/CastExpr.java
* tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/LogicalPlanner.java
* tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/SQLAnalyzer.java
* tajo-algebra/src/main/java/org/apache/tajo/algebra/Target.java
* tajo-algebra/src/main/java/org/apache/tajo/algebra/DataTypeExpr.java
* tajo-algebra/src/main/java/org/apache/tajo/algebra/Aggregation.java
* tajo-algebra/src/test/java/org/apache/tajo/algebra/TestExpr.java
* tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/planner/BaseAlgebraVisitor.java
* tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/engine/parser/HiveConverter.java
* CHANGES.txt
* tajo-algebra/src/main/java/org/apache/tajo/algebra/TargetExpr.java


> Add missing visitor methods of AlgebraVisitor and BaseAlgebraVisitor
> --------------------------------------------------------------------
>
>                 Key: TAJO-419
>                 URL: https://issues.apache.org/jira/browse/TAJO-419
>             Project: Tajo
>          Issue Type: Improvement
>          Components: parser, planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-419.patch
>
>
> This patch primarily adds all missing operator types' visitor methods of AlgebraVisitor
and implements concrete methods in BaseAlgebraVisitor. Currently, BaseAlgebraVisitor may cause
incorrect PlanningException because BaseAlgebraVisitor does not handle all operator types.
This patch eliminates this potential bug.
> In addition, this patch contains two refactors in order to eliminate duplicate names:
>  * Rename tajo.algebra.DataType to DataTypeExpr
>  * Rename tajo.algebra.Target to TargetExpr



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message