tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jihoon Son (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-382) Implement encode function
Date Wed, 18 Dec 2013 06:14:07 GMT

    [ https://issues.apache.org/jira/browse/TAJO-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13851413#comment-13851413
] 

Jihoon Son commented on TAJO-382:
---------------------------------

In overall, this patch looks good to me.
I suggest a couple of things to improve the patch.
* I found some codes that violates our coding convention (https://wiki.apache.org/tajo/CodingStyle).
It would be better to follow the coding convention for keeping the consistency and improving
the readability.
* The eval() function of the Encode/Decode class just prints the stack trace when an exception
occurs during encoding/decoding. It would be better to return a NullDatum when an exception
occurs.

> Implement encode function
> -------------------------
>
>                 Key: TAJO-382
>                 URL: https://issues.apache.org/jira/browse/TAJO-382
>             Project: Tajo
>          Issue Type: New Feature
>            Reporter: Seungun Choe
>            Assignee: Seungun Choe
>            Priority: Minor
>         Attachments: TAJO-382.patch, TAJO-382_2.patch
>
>
> Function : encode(data bytea, format text)
> Description : Encode binary data into a textual representation. Supported formats are:
base64, hex, escape. escape converts zero bytes and high-bit-set bytes to octal sequences
(\nnn) and doubles backslashes.
> Example : encode(E'123\\000\\001', 'base64')  -->  MTIzAAE=



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message