tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prafulla T (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (TAJO-182) Comparison of primitive values including null value should return NULL.
Date Fri, 20 Dec 2013 01:40:07 GMT

    [ https://issues.apache.org/jira/browse/TAJO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13853469#comment-13853469
] 

Prafulla T edited comment on TAJO-182 at 12/20/13 1:38 AM:
-----------------------------------------------------------

Sure,
Here are my review comments.
---
Float4Datum::compareTo should raise exception when NullValue is seen? Just to be safe?
I see that we can do this in almost all other classes Int,Text etc.

Type of a > NULL should be Boolean OR NULL ? If NULL, we need to change type determination
logic?

For NULL with AND /OR, we need to consider three value logic?
https://en.wikipedia.org/wiki/Three-valued_logic
---




was (Author: prafulla):
Sure,
Here are my review comments.
---
Float4Datum::compareTo should raise exception when NullValue is seen? Just to be safe?
I see that we can do this in almost all other classes Int,Text etc.

Type of a > NULL should be Boolean OR NULL ? If NULL, we need to change type determination
logic?

For NULL with AND /OR, we need to consider three value logic?
https://en.wikipedia.org/wiki/Three-valued_logic
---

I also wanted to know if Tajo project can use apache review board, it is much easier and use
friendly. 


> Comparison of primitive values including null value should return NULL.
> -----------------------------------------------------------------------
>
>                 Key: TAJO-182
>                 URL: https://issues.apache.org/jira/browse/TAJO-182
>             Project: Tajo
>          Issue Type: Bug
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>            Priority: Critical
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-182.patch
>
>
> -If some domain value is compared to Null value, the current implementation will cause
InvalidOperationException. Such cases should result in 'false'.-
> If some domain value is compared to Null value, the current implementation will cause
either InvalidOperationException or FALSE. Such cases should result in NULL.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message