tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyunsik Choi (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (TAJO-182) Correct NULL value handling of primitive operators
Date Sun, 22 Dec 2013 14:57:50 GMT

     [ https://issues.apache.org/jira/browse/TAJO-182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hyunsik Choi updated TAJO-182:
------------------------------

    Attachment: TAJO-182_3.patch

Thank you Jihoon for your review!

Yes, this patch includes many issues, but almost of all modifications are for NULL value handling
and bug fixes caused by the correction of null value handling. For example, after I corrected
null comparison, scan filter and outer join operators incurred errors. This patch also includes
the fix. 

Actually, so far, we have considered a little bit of null values handling in many parts of
datums and expressions. In this issue, I've tried to cover all null value comparisons throughout
the code. In order to represent the goal of this issue, I've changed the issue title to 'Correct
Null value handling of primitive operators. 

I'm still not sure that it patch covers all parts. I think that we should continue to find
and fix the wrong code that we haven't found. In addition, we should add more unit tests.

I've uploaded the third patch. This patch reflects your suggestion and includes the fix of
missed null value handling. 

Merry Christmas!

> Correct NULL value handling of primitive operators
> --------------------------------------------------
>
>                 Key: TAJO-182
>                 URL: https://issues.apache.org/jira/browse/TAJO-182
>             Project: Tajo
>          Issue Type: Bug
>          Components: planner/optimizer
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>            Priority: Critical
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-182.patch, TAJO-182_2.patch, TAJO-182_3.patch
>
>
> -If some domain value is compared to Null value, the current implementation will cause
InvalidOperationException. Such cases should result in 'false'.-
> -If some domain value is compared to Null value, the current implementation will cause
either InvalidOperationException or FALSE. Such cases should result in NULL.-
> Many primitive operators including arithmetic and comparison do not consider three valued
logic. This patch corrects this problem. The original issue title was 'Comparison of primitive
values including null value should return NULL.' This issue was expanded for null value handling
of all primitive operators.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Mime
View raw message