tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyunsik Choi (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (TAJO-164) Maven plugin for code style
Date Thu, 19 Dec 2013 14:42:09 GMT

     [ https://issues.apache.org/jira/browse/TAJO-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hyunsik Choi updated TAJO-164:
------------------------------

    Priority: Major  (was: Minor)

> Maven plugin for code style
> ---------------------------
>
>                 Key: TAJO-164
>                 URL: https://issues.apache.org/jira/browse/TAJO-164
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Sergio Esteves
>
> While merging some code, I've been noticing that different developers (including me)
have been using different styles.
> Examples:
> a)
> {code}
> switch(...) {
>   case ...
> {code}
> instead of
> {code}
> switch(...) {
> case ...
> {code}
> b) "private long estimateSizeRecursive(TaskAttemptContext ctx, String [] tableIds) {"
<- space between "String" and "[]".
> c) Mixing tabs with spaces.
> d) 
> {code}
> import org.apache.hadoop.yarn.state.*;
> {code}
> instead of
> {code}
> import org.apache.hadoop.yarn.state.InvalidStateTransitonException;
> import org.apache.hadoop.yarn.state.MultipleArcTransition;
> import org.apache.hadoop.yarn.state.SingleArcTransition;
> import org.apache.hadoop.yarn.state.StateMachine;
> import org.apache.hadoop.yarn.state.StateMachineFactory;
> {code}
> I think it might be useful, to ensure everyone is adopting the same style, to include
a maven plugin to check if the code style is in accordance with tajo rules (e.g., http://maven.apache.org/plugins/maven-checkstyle-plugin/
).



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Mime
View raw message