Return-Path: X-Original-To: apmail-tajo-dev-archive@minotaur.apache.org Delivered-To: apmail-tajo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3B80910C83 for ; Sun, 24 Nov 2013 06:45:34 +0000 (UTC) Received: (qmail 36565 invoked by uid 500); 24 Nov 2013 06:45:31 -0000 Delivered-To: apmail-tajo-dev-archive@tajo.apache.org Received: (qmail 36534 invoked by uid 500); 24 Nov 2013 06:45:30 -0000 Mailing-List: contact dev-help@tajo.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tajo.incubator.apache.org Delivered-To: mailing list dev@tajo.incubator.apache.org Received: (qmail 36521 invoked by uid 99); 24 Nov 2013 06:45:28 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Nov 2013 06:45:28 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 24 Nov 2013 06:44:55 +0000 Received: (qmail 36480 invoked by uid 99); 24 Nov 2013 06:44:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Nov 2013 06:44:35 +0000 Date: Sun, 24 Nov 2013 06:44:35 +0000 (UTC) From: "Hyunsik Choi (JIRA)" To: dev@tajo.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TAJO-323) Refactor inconsistent class and variable names MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TAJO-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13830882#comment-13830882 ] Hyunsik Choi commented on TAJO-323: ----------------------------------- QueryBlock already exists in order to represent a query block in a SQL query. A query consists multiple ExecutionBlocks, each of which is a step in a query. SubQuery in current implementation is an in-progress state of an execution block. So, I would like to name it ExecutionBlockInProgress. Actually, I'm making a development document about query life cycle, hierarchy of query and tasks, and their relationship for helping developers as well as this refactoring. With this document, we can discuss it more detail. > Refactor inconsistent class and variable names > ---------------------------------------------- > > Key: TAJO-323 > URL: https://issues.apache.org/jira/browse/TAJO-323 > Project: Tajo > Issue Type: Task > Reporter: Hyunsik Choi > Fix For: 0.8-incubating > > > There are inconsistent class and variable names. For example, QueryUnit and task are used in a mixing way, and QueryUnitAttempt and taskattempt are used in a mixing way. They reduce readability and make developers confuse. > Now is the right time to correct them. The main object of this issue is to investigate those inconsistent class and variable names and correct them. > However, this work may make many conflicts. In order to minimize the code conflict, we need to make a number of small separate refactors. -- This message was sent by Atlassian JIRA (v6.1#6144)