tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jihoon Son (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-303) Improve FragmentProto to be extendable
Date Thu, 14 Nov 2013 06:25:24 GMT

    [ https://issues.apache.org/jira/browse/TAJO-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822207#comment-13822207
] 

Jihoon Son commented on TAJO-303:
---------------------------------

Hyunsik, thanks for your comment.

I think that there is a need to have the super-child class relationship between Fragment and
FileFragment, because they share a value, id. (Although they share only one value, it might
increase the complexity of the codes.)

Also, I think that it will be better that their proto types have the inheritance relationship,
but it is hard to implement because PB doesn't support the polymorphism of the OOP. In addition,
the PB's extended messages decrease the readability and productivity of the codes due to the
complex usage. So I will remove this portion from the patch.

I'm looking forward your comment.

> Improve FragmentProto to be extendable
> --------------------------------------
>
>                 Key: TAJO-303
>                 URL: https://issues.apache.org/jira/browse/TAJO-303
>             Project: Tajo
>          Issue Type: Improvement
>    Affects Versions: 0.8-incubating
>            Reporter: Jihoon Son
>            Assignee: Jihoon Son
>         Attachments: TAJO-303.patch, TAJO-303_2.patch
>
>
> Fragment is designed to support various types of stores, and thus FragmentProto should
be designed considering the expandability.
> This issue will increase readability and productivity.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message