tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyunsik Choi (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (TAJO-176) Implement Tajo JDBC Driver
Date Mon, 18 Nov 2013 00:41:22 GMT

    [ https://issues.apache.org/jira/browse/TAJO-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13825010#comment-13825010
] 

Hyunsik Choi edited comment on TAJO-176 at 11/18/13 12:40 AM:
--------------------------------------------------------------

Great job!

In overall, the patch looks great for me. The extensive unit tests are also nice.

In addition to the points that Jihoon mentioned, there are additional things to be improved.

* java.sql.DatabaseMetaData and java.sql.Driver have additional methods in JDK 7. So, the
current patch cannot be compiled and work in java 7. It can be solved by overriding java.sql.DatabaseMetaData
and java.sql.Driver of JDK7 without @Override annotation.
* There are many unused imports. You can find them in TajoDriver, TajoResultSetMetaData, TajoResultSetBase,
TestTajoJdbc, and TajoResultSet classes.


was (Author: hyunsik):
Great job!

In overall, the patch looks great for me. The extensive unit tests are also nice.

But, there are a few of things to be improved.

* java.sql.DatabaseMetaData and java.sql.Driver have additional methods in JDK 7. So, the
current patch cannot be compiled and work in java 7. It can be solved by overriding java.sql.DatabaseMetaData
and java.sql.Driver of JDK7 without @Override annotation.
* There are many unused imports. You can find them in TajoDriver, TajoResultSetMetaData, TajoResultSetBase,
TestTajoJdbc, and TajoResultSet classes.

> Implement Tajo JDBC Driver
> --------------------------
>
>                 Key: TAJO-176
>                 URL: https://issues.apache.org/jira/browse/TAJO-176
>             Project: Tajo
>          Issue Type: New Feature
>          Components: client
>            Reporter: Hyunsik Choi
>            Assignee: Keuntae Park
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-176.patch
>
>
> Tajo is required to be integrated with legacy BI or OLAP tools. For this, Tajo should
provide a JDBC driver.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message