Return-Path: X-Original-To: apmail-tajo-dev-archive@minotaur.apache.org Delivered-To: apmail-tajo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 997861027D for ; Wed, 30 Oct 2013 14:46:43 +0000 (UTC) Received: (qmail 56518 invoked by uid 500); 30 Oct 2013 14:39:25 -0000 Delivered-To: apmail-tajo-dev-archive@tajo.apache.org Received: (qmail 56336 invoked by uid 500); 30 Oct 2013 14:39:18 -0000 Mailing-List: contact dev-help@tajo.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tajo.incubator.apache.org Delivered-To: mailing list dev@tajo.incubator.apache.org Received: (qmail 56241 invoked by uid 99); 30 Oct 2013 14:39:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Oct 2013 14:39:00 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 30 Oct 2013 14:38:58 +0000 Received: (qmail 36901 invoked by uid 99); 30 Oct 2013 14:27:40 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Oct 2013 14:27:40 +0000 Date: Wed, 30 Oct 2013 14:27:40 +0000 (UTC) From: "Jihoon Son (JIRA)" To: dev@tajo.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TAJO-294) Removing dead worker from live worker list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TAJO-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809146#comment-13809146 ] Jihoon Son commented on TAJO-294: --------------------------------- It is a great work, but there are some minor issues. * First of all, when TajoWorkerResourceManager.close() is called, WorkerMonitor.interrupt() should be called instead of WorkerMonitor.interrupted(). * Also, it will be better that class names represent their properties. So, how about change the class name of WorkerMonitor to WorkerMonitorThread like WorkerResourceAllocationThread? * I got the following message while applying the patch. Submit clean patch files, please. {code} $ patch -p0 < TAJO-294.patch (Stripping trailing CRs from patch.) patching file tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java (Stripping trailing CRs from patch.) patching file tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/rm/TajoWorkerResourceManager.java (Stripping trailing CRs from patch.) patching file tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/rm/WorkerResource.java (Stripping trailing CRs from patch.) patching file tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java (Stripping trailing CRs from patch.) patching file tajo-core/tajo-core-backend/src/main/resources/webapps/admin/catalogview.jsp (Stripping trailing CRs from patch.) patching file tajo-core/tajo-core-backend/src/main/resources/webapps/admin/cluster.jsp (Stripping trailing CRs from patch.) patching file tajo-core/tajo-core-backend/src/main/resources/webapps/worker/index.jsp {code} > Removing dead worker from live worker list > ------------------------------------------ > > Key: TAJO-294 > URL: https://issues.apache.org/jira/browse/TAJO-294 > Project: Tajo > Issue Type: Bug > Reporter: Keuntae Park > Assignee: Keuntae Park > Attachments: TAJO-294.patch > > > Currently, even if a worker does not work properly, > it remains as live and and participates in a plan. > Web management console also displays the worker as live. > It should be set as dead, and displaying last heartbeat time in web management console is probably helpful. > -- This message was sent by Atlassian JIRA (v6.1#6144)