Return-Path: X-Original-To: apmail-tajo-dev-archive@minotaur.apache.org Delivered-To: apmail-tajo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8405210671 for ; Sun, 27 Oct 2013 09:25:05 +0000 (UTC) Received: (qmail 9666 invoked by uid 500); 27 Oct 2013 09:25:04 -0000 Delivered-To: apmail-tajo-dev-archive@tajo.apache.org Received: (qmail 9530 invoked by uid 500); 27 Oct 2013 09:25:04 -0000 Mailing-List: contact dev-help@tajo.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tajo.incubator.apache.org Delivered-To: mailing list dev@tajo.incubator.apache.org Received: (qmail 9505 invoked by uid 99); 27 Oct 2013 09:24:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Oct 2013 09:24:55 +0000 X-ASF-Spam-Status: No, hits=-2000.4 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 27 Oct 2013 09:24:53 +0000 Received: (qmail 9486 invoked by uid 99); 27 Oct 2013 09:24:31 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Oct 2013 09:24:31 +0000 Date: Sun, 27 Oct 2013 09:24:31 +0000 (UTC) From: "Jihoon Son (JIRA)" To: dev@tajo.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (TAJO-287) Improve Fragment to be more generic MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TAJO-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806296#comment-13806296 ] Jihoon Son edited comment on TAJO-287 at 10/27/13 9:24 AM: ----------------------------------------------------------- ++1 for this issue. It has a great extensibility. I have a couple of things that we need to discuss. * FileFragment has getStartKey() and getEndKey() which are inherited from Fragment. These functions return a start offset and a length, respectively. But, their names are not intuitive to suppose what their values mean. How about add getStartOffset() and getLength() function to only FileFragment? * In Task, there are some commented out codes and you left a comment as "TODO - to be fixed". What does the comment mean? was (Author: jihoonson): ++1 for this issue. It has a great extensibility. I have a couple of things that we need to discuss. * FileFragment has getStartKey() and getEndKey() which are inherited from Fragment. These functions return a start offset and a length, respectively. But, their names are not intuitive to suppose what their values mean. How about you add getStartOffset() and getLength() function to only FileFragment? * In Task, there are some commented out codes and you left a comment as "TODO - to be fixed". What does the comment mean? > Improve Fragment to be more generic > ----------------------------------- > > Key: TAJO-287 > URL: https://issues.apache.org/jira/browse/TAJO-287 > Project: Tajo > Issue Type: Improvement > Components: physical operator > Reporter: Hyunsik Choi > Assignee: Hyunsik Choi > Fix For: 0.8-incubating > > Attachments: TAJO-287.patch > > > The current Fragment is only for a file. This patch improves Fragment to be more generic. > First of all, I've changed Fragment to an interface and the original Fragment to FileFragment respectively. FragmentProto is changed to contain a table name and a bytestring which contains an storage-dependent contents. Then, the added FragmentConvertor transforms FragmentProto to a specified Fragment instance. It would be very useful to represent various fragment types like a row range of Hbase and database tables. -- This message was sent by Atlassian JIRA (v6.1#6144)