Return-Path: X-Original-To: apmail-tajo-dev-archive@minotaur.apache.org Delivered-To: apmail-tajo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4651C10420 for ; Sun, 27 Oct 2013 07:02:03 +0000 (UTC) Received: (qmail 18371 invoked by uid 500); 27 Oct 2013 07:02:01 -0000 Delivered-To: apmail-tajo-dev-archive@tajo.apache.org Received: (qmail 18329 invoked by uid 500); 27 Oct 2013 07:01:59 -0000 Mailing-List: contact dev-help@tajo.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tajo.incubator.apache.org Delivered-To: mailing list dev@tajo.incubator.apache.org Received: (qmail 18317 invoked by uid 99); 27 Oct 2013 07:01:58 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Oct 2013 07:01:58 +0000 X-ASF-Spam-Status: No, hits=-2000.4 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 27 Oct 2013 07:01:55 +0000 Received: (qmail 18297 invoked by uid 99); 27 Oct 2013 07:01:32 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 27 Oct 2013 07:01:32 +0000 Date: Sun, 27 Oct 2013 07:01:32 +0000 (UTC) From: "Hyunsik Choi (JIRA)" To: dev@tajo.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (TAJO-286) Refactor TableDesc, TableMeta, and Fragment MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TAJO-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hyunsik Choi updated TAJO-286: ------------------------------ Resolution: Fixed Status: Resolved (was: Patch Available) Thank you for the review. As you mentioned, I've modified the commented out tests in TestFragment. > Refactor TableDesc, TableMeta, and Fragment > ------------------------------------------- > > Key: TAJO-286 > URL: https://issues.apache.org/jira/browse/TAJO-286 > Project: Tajo > Issue Type: Improvement > Components: catalog > Reporter: Hyunsik Choi > Assignee: Hyunsik Choi > Fix For: 0.8-incubating > > Attachments: PATCH-286.patch > > > In the current implementation, TableDesc and TableMeta are implemented through interface and its implementation. This is unnecessary abstraction. For simplicity, this patch removes interfaces and merge them into the concrete classes. > In addition, TableDesc and TableMeta's role is ambiguous. This patch clarifies their roles as follows: > * TableMeta contains usual physical information which is used in workers. > * TableDesc contains logical information about a table and others which are not used in workers. > As a result, I've moved TableStats and Schema from TableMeta to TableDesc. > Besides, in the current implementation, Fragment also is subclassed of TableDesc. But, this relationship is wrong. Fragment is independent one of TableDesc. This patch changes this relationship. They are independent ones. -- This message was sent by Atlassian JIRA (v6.1#6144)