Return-Path: X-Original-To: apmail-tajo-dev-archive@minotaur.apache.org Delivered-To: apmail-tajo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F291210518 for ; Fri, 25 Oct 2013 05:05:01 +0000 (UTC) Received: (qmail 7629 invoked by uid 500); 25 Oct 2013 05:05:01 -0000 Delivered-To: apmail-tajo-dev-archive@tajo.apache.org Received: (qmail 7506 invoked by uid 500); 25 Oct 2013 05:04:57 -0000 Mailing-List: contact dev-help@tajo.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tajo.incubator.apache.org Delivered-To: mailing list dev@tajo.incubator.apache.org Received: (qmail 7489 invoked by uid 99); 25 Oct 2013 05:04:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Oct 2013 05:04:56 +0000 X-ASF-Spam-Status: No, hits=-2000.4 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 25 Oct 2013 05:04:52 +0000 Received: (qmail 6641 invoked by uid 99); 25 Oct 2013 05:04:30 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Oct 2013 05:04:30 +0000 Date: Fri, 25 Oct 2013 05:04:30 +0000 (UTC) From: "Jihoon Son (JIRA)" To: dev@tajo.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (TAJO-275) Separating QueryMaster and TaskRunner roles in worker MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TAJO-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13805040#comment-13805040 ] Jihoon Son commented on TAJO-275: --------------------------------- +1. This patch looks good to me. It passes 'mvn clean verify'. > Separating QueryMaster and TaskRunner roles in worker > ----------------------------------------------------- > > Key: TAJO-275 > URL: https://issues.apache.org/jira/browse/TAJO-275 > Project: Tajo > Issue Type: Improvement > Reporter: Keuntae Park > Assignee: Keuntae Park > Attachments: TAJO-275.patch, TAJO-275.patch_2 > > > In C++ implementation of Tajo worker, > I think it is better to maintain Java code of QueryMaster and implement only TaskRunner as C++ code, rather than implementing both QueryMaster and TaskRunner as C++ code. > Accordingly, standby mode worker will have following 3 modes: > 1) TaskRunner + QueryMaster (current implementation) > 2) TaskRunner only (C++) > 3) QueryMaster only (java) > And, most workers work as C++ TaskRunner, and 1 or 2 workers work as separate QueryMasters (java process). > For backward compatibility, default mode should be mode 1 (TaskRunner + QueryMaster) > To achieve the goal, it needs to separate java TaskRunner and java QueryMaster Worker first. > (And then, implement C++ TaskRunner) -- This message was sent by Atlassian JIRA (v6.1#6144)