Mailing-List: contact dev-help@tajo.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@tajo.incubator.apache.org
Date: Fri, 25 Oct 2013 02:42:03 +0000 (UTC)
From: "Jihoon Son (JIRA)" <jira@apache.org>
To: dev@tajo.incubator.apache.org
Message-ID: <JIRA.12674924.1382399092301.6950.1382668923822@arcas>
In-Reply-To: <JIRA.12674924.1382399092301@arcas>
References: <JIRA.12674924.1382399092301@arcas>
Subject: [jira] [Comment Edited] (TAJO-274) Maintaining connectivity to Tajo
 master even though the restart of the Tajo master
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/TAJO-274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804951#comment-13804951 ] 

Jihoon Son edited comment on TAJO-274 at 10/25/13 2:41 AM:
-----------------------------------------------------------

Thanks for your contribution, 
but this patch includes some strange codes like this.

{code}
In TajoWorker
private void connectToTajoMaster(String tajoMasterAddrString) {
  LOG.info("Connecting to TajoMaster (" + tajoMasterAddrString +")");
  this.tajoMasterAddress = NetUtils.createSocketAddr(tajoMasterAddrString);

  while(true) {
    try {
//        tajoMasterRpc = new AsyncRpcClient(TajoMasterProtocol.class, this.tajoMasterAddress);
//        tajoMasterRpcClient = tajoMasterRpc.getStub();
      break;
    } catch (Exception e) {
      LOG.error("Can't connect to TajoMaster[" + NetUtils.normalizeInetSocketAddress(tajoMasterAddress) + "], "
          + e.getMessage(), e);
    }
     try {
      Thread.sleep(3000);
    } catch (InterruptedException e) {
    }
  }
}
{code}


was (Author: jihoonson):
Thanks for your contribution, 
but this patch some strange codes like this.

{code}
In TajoWorker
private void connectToTajoMaster(String tajoMasterAddrString) {
  LOG.info("Connecting to TajoMaster (" + tajoMasterAddrString +")");
  this.tajoMasterAddress = NetUtils.createSocketAddr(tajoMasterAddrString);

  while(true) {
    try {
//        tajoMasterRpc = new AsyncRpcClient(TajoMasterProtocol.class, this.tajoMasterAddress);
//        tajoMasterRpcClient = tajoMasterRpc.getStub();
      break;
    } catch (Exception e) {
      LOG.error("Can't connect to TajoMaster[" + NetUtils.normalizeInetSocketAddress(tajoMasterAddress) + "], "
          + e.getMessage(), e);
    }
     try {
      Thread.sleep(3000);
    } catch (InterruptedException e) {
    }
  }
}
{code}

> Maintaining connectivity to Tajo master even though the restart of the Tajo master
> ----------------------------------------------------------------------------------
>
>                 Key: TAJO-274
>                 URL: https://issues.apache.org/jira/browse/TAJO-274
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Keuntae Park
>         Attachments: TAJO-274.patch
>
>
> Currently, when you restart the Tajo master, you should restart all the workers and clients also.
> When client or worker has problem with connection to Tajo master due to the master restart, it needs to close the previous connection and try to reconnect to the master


--
This message was sent by Atlassian JIRA
(v6.1#6144)