tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jihoon Son (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-294) Removing dead worker from live worker list
Date Wed, 30 Oct 2013 14:27:40 GMT

    [ https://issues.apache.org/jira/browse/TAJO-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13809146#comment-13809146
] 

Jihoon Son commented on TAJO-294:
---------------------------------

It is a great work, but there are some minor issues.
* First of all, when TajoWorkerResourceManager.close() is called, WorkerMonitor.interrupt()
should be called instead of WorkerMonitor.interrupted().
* Also, it will be better that class names represent their properties. So, how about change
the class name of WorkerMonitor to WorkerMonitorThread like WorkerResourceAllocationThread?
* I got the following message while applying the patch. Submit clean patch files, please.
{code}
$ patch -p0 < TAJO-294.patch
(Stripping trailing CRs from patch.)
patching file tajo-common/src/main/java/org/apache/tajo/conf/TajoConf.java
(Stripping trailing CRs from patch.)
patching file tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/rm/TajoWorkerResourceManager.java
(Stripping trailing CRs from patch.)
patching file tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/master/rm/WorkerResource.java
(Stripping trailing CRs from patch.)
patching file tajo-core/tajo-core-backend/src/main/java/org/apache/tajo/util/JSPUtil.java
(Stripping trailing CRs from patch.)
patching file tajo-core/tajo-core-backend/src/main/resources/webapps/admin/catalogview.jsp
(Stripping trailing CRs from patch.)
patching file tajo-core/tajo-core-backend/src/main/resources/webapps/admin/cluster.jsp
(Stripping trailing CRs from patch.)
patching file tajo-core/tajo-core-backend/src/main/resources/webapps/worker/index.jsp
{code}

> Removing dead worker from live worker list
> ------------------------------------------
>
>                 Key: TAJO-294
>                 URL: https://issues.apache.org/jira/browse/TAJO-294
>             Project: Tajo
>          Issue Type: Bug
>            Reporter: Keuntae Park
>            Assignee: Keuntae Park
>         Attachments: TAJO-294.patch
>
>
> Currently, even if a worker does not work properly,
> it remains as live and and participates in a plan.
> Web management console also displays the worker as live.
> It should be set as dead, and displaying last heartbeat time in web management console
is probably helpful.
>  



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message