tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hyunsik Choi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-287) Improve Fragment to be more generic
Date Sun, 27 Oct 2013 10:39:30 GMT

    [ https://issues.apache.org/jira/browse/TAJO-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806303#comment-13806303

Hyunsik Choi commented on TAJO-287:

I will handle the TODO that I missed. 

Because getStartOffset and getLength will be called in file scanners, your suggestion is reasonable.
I expected that the generic start key and end key may be used in QueryMaster without the fragment
specific code. However, I can't imagine any usage cases now. Now, I'm going to accept your

Thank you for the nice review.

> Improve Fragment to be more generic
> -----------------------------------
>                 Key: TAJO-287
>                 URL: https://issues.apache.org/jira/browse/TAJO-287
>             Project: Tajo
>          Issue Type: Improvement
>          Components: physical operator
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating
>         Attachments: TAJO-287.patch
> The current Fragment is only for a file. This patch improves Fragment to be more generic.

> First of all, I've changed Fragment to an interface and the original Fragment to FileFragment
respectively. FragmentProto is changed to contain a table name and a bytestring which contains
an storage-dependent contents. Then, the added FragmentConvertor transforms FragmentProto
to a specified Fragment instance. It would be very useful to represent various fragment types
like a row range of Hbase and database tables.

This message was sent by Atlassian JIRA

View raw message