tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jihoon Son (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-287) Improve Fragment to be more generic
Date Sun, 27 Oct 2013 09:24:30 GMT

    [ https://issues.apache.org/jira/browse/TAJO-287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13806296#comment-13806296
] 

Jihoon Son commented on TAJO-287:
---------------------------------

++1 for this issue. It has a great extensibility. 
I have a couple of things that we need to discuss.
* FileFragment has getStartKey() and getEndKey() which are inherited from Fragment. These
functions return a start offset and a length, respectively. But, their names are not intuitive
to suppose what their values mean. How about you add getStartOffset() and getLength() function
to only FileFragment?
* In Task, there are some commented out codes and you left a comment as "TODO - to be fixed".
What does the comment mean?

> Improve Fragment to be more generic
> -----------------------------------
>
>                 Key: TAJO-287
>                 URL: https://issues.apache.org/jira/browse/TAJO-287
>             Project: Tajo
>          Issue Type: Improvement
>          Components: physical operator
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-287.patch
>
>
> The current Fragment is only for a file. This patch improves Fragment to be more generic.

> First of all, I've changed Fragment to an interface and the original Fragment to FileFragment
respectively. FragmentProto is changed to contain a table name and a bytestring which contains
an storage-dependent contents. Then, the added FragmentConvertor transforms FragmentProto
to a specified Fragment instance. It would be very useful to represent various fragment types
like a row range of Hbase and database tables.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message