tajo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jihoon Son (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (TAJO-254) Refactor package names and class names to have proper names
Date Wed, 16 Oct 2013 02:45:42 GMT

    [ https://issues.apache.org/jira/browse/TAJO-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796353#comment-13796353
] 

Jihoon Son commented on TAJO-254:
---------------------------------

+1

This patch looks good to me.
It passes 'mvn clean install -DskipTests'

> Refactor package names and class names to have proper names
> -----------------------------------------------------------
>
>                 Key: TAJO-254
>                 URL: https://issues.apache.org/jira/browse/TAJO-254
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.2-incubating
>
>         Attachments: TAJO-254_2.patch, TAJO-254.patch
>
>
> This package removes unused classes and files :
>  * FragmentDeserializer
>  * scheduler/event/*
>  * Callback in tajo-rpc
>  * NettyAsyncRpcProxy
>  * NettyBlockingRpcProxy
>  * NettyRpc
>  * NettyRpcServer
>  * rpc/benchmark/* in tajo-rpc
>  * ProtoParamRpcProtocol.proto
>  * ProtoParamRpcProtos.proto
> Also, this patch renames as follows:
>  * CallFuture2 to CallFuture
>  * ProtoAsyncRpc* -> AsyncRpc*
>  * ProtoBlockingRpc* -> BlockingRpc*
> Finally, this patch moves InCountry and Country functions from tajo/engine/function package
to tajo/engine/function/geo package.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Mime
View raw message