Return-Path: X-Original-To: apmail-tajo-dev-archive@minotaur.apache.org Delivered-To: apmail-tajo-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3C4B910775 for ; Fri, 6 Sep 2013 03:50:14 +0000 (UTC) Received: (qmail 50925 invoked by uid 500); 6 Sep 2013 03:50:14 -0000 Delivered-To: apmail-tajo-dev-archive@tajo.apache.org Received: (qmail 50896 invoked by uid 500); 6 Sep 2013 03:50:14 -0000 Mailing-List: contact dev-help@tajo.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@tajo.incubator.apache.org Delivered-To: mailing list dev@tajo.incubator.apache.org Received: (qmail 50887 invoked by uid 99); 6 Sep 2013 03:50:13 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Sep 2013 03:50:13 +0000 X-ASF-Spam-Status: No, hits=-2002.4 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 06 Sep 2013 03:50:12 +0000 Received: (qmail 50761 invoked by uid 99); 6 Sep 2013 03:49:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Sep 2013 03:49:51 +0000 Date: Fri, 6 Sep 2013 03:49:51 +0000 (UTC) From: "Sergio Esteves (JIRA)" To: dev@tajo.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (TAJO-164) Maven plugin for code style MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/TAJO-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sergio Esteves updated TAJO-164: -------------------------------- Priority: Minor (was: Major) > Maven plugin for code style > --------------------------- > > Key: TAJO-164 > URL: https://issues.apache.org/jira/browse/TAJO-164 > Project: Tajo > Issue Type: Improvement > Reporter: Sergio Esteves > Priority: Minor > > While merging some code, I've been noticing that different developers (including me) have been using different styles. > Examples: > a) > {code} > switch(...) { > case ... > {code} > instead of > {code} > switch(...) { > case ... > {code} > b) "private long estimateSizeRecursive(TaskAttemptContext ctx, String [] tableIds) {" <- space between "String" and "[]". > c) Mixing tabs with spaces. > d) > {code} > import org.apache.hadoop.yarn.state.*; > {code} > instead of > {code} > import org.apache.hadoop.yarn.state.InvalidStateTransitonException; > import org.apache.hadoop.yarn.state.MultipleArcTransition; > import org.apache.hadoop.yarn.state.SingleArcTransition; > import org.apache.hadoop.yarn.state.StateMachine; > import org.apache.hadoop.yarn.state.StateMachineFactory; > {code} > I think it might be useful, to ensure everyone is adopting the same style, to include a maven plugin to check if the code style is in accordance with tajo rules (e.g., http://maven.apache.org/plugins/maven-checkstyle-plugin/ ). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira