systemml-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "bd2019us (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SYSTEMML-2526) Date.getTime() can be changed to System.currentTimeMillis()
Date Fri, 12 Apr 2019 15:50:00 GMT

     [ https://issues.apache.org/jira/browse/SYSTEMML-2526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

bd2019us updated SYSTEMML-2526:
-------------------------------
    Description: 
Hello,

I found that System.currentTimeMillis() can be used here instead of new Date.getTime().
Since new Date() is a thin wrapper of light method System.currentTimeMillis(). The performance
will be greatly damaged if it is invoked too much times.
According to my local testing at the same environment, System.currentTimeMillis() can achieve
a speedup to 5 times (435 ms vs 2073 ms), when these two methods are invoked 5,000,000 times.

  was:
src/main/java/org/apache/sysml/api/mlcontext/MLContext.java 337
src/main/java/org/apache/sysml/api/mlcontext/MLContextUtil.java 1258

I found that System.currentTimeMillis() can be used here instead of new Date.getTime().
Since new Date() is a thin wrapper of light method System.currentTimeMillis(). The performance
will be greatly damaged if it is invoked too much times.
According to my local testing at the same environment, System.currentTimeMillis() can achieve
a speedup to 5 times (435 ms vs 2073 ms), when these two methods are invoked 5,000,000 times.


> Date.getTime() can be changed to System.currentTimeMillis()
> -----------------------------------------------------------
>
>                 Key: SYSTEMML-2526
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-2526
>             Project: SystemML
>          Issue Type: Bug
>            Reporter: bd2019us
>            Priority: Major
>         Attachments: 1.patch
>
>
> Hello,
> I found that System.currentTimeMillis() can be used here instead of new Date.getTime().
> Since new Date() is a thin wrapper of light method System.currentTimeMillis(). The performance
will be greatly damaged if it is invoked too much times.
> According to my local testing at the same environment, System.currentTimeMillis() can
achieve a speedup to 5 times (435 ms vs 2073 ms), when these two methods are invoked 5,000,000
times.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message