From issues-return-8154-archive-asf-public=cust-asf.ponee.io@systemml.apache.org Thu Apr 5 01:59:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BA252180677 for ; Thu, 5 Apr 2018 01:59:05 +0200 (CEST) Received: (qmail 63880 invoked by uid 500); 4 Apr 2018 23:59:04 -0000 Mailing-List: contact issues-help@systemml.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@systemml.apache.org Delivered-To: mailing list issues@systemml.apache.org Received: (qmail 63871 invoked by uid 99); 4 Apr 2018 23:59:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 23:59:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 64C94C00E0 for ; Wed, 4 Apr 2018 23:59:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Sd-NMt2nZpJp for ; Wed, 4 Apr 2018 23:59:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 42E165F5DD for ; Wed, 4 Apr 2018 23:59:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5017EE0F13 for ; Wed, 4 Apr 2018 23:59:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 6FD5425626 for ; Wed, 4 Apr 2018 23:59:00 +0000 (UTC) Date: Wed, 4 Apr 2018 23:59:00 +0000 (UTC) From: "Matthias Boehm (JIRA)" To: issues@systemml.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (SYSTEMML-2232) Logical namespace handling user-defined functions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/SYSTEMML-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426349#comment-16426349 ] Matthias Boehm commented on SYSTEMML-2232: ------------------------------------------ Well, this would likely create problems regarding recursive namespace resolution, so I would recommend to keep both the filename and the logical namespace. This way the current runtime remains unchanged but we can use the logical name spaces where needed (e.g., for better stats output and namespace functions in eval). However, not that I recommend this task for a potential new contributor, so it would be polite to leave this task open for a while: https://www.mail-archive.com/dev@systemml.apache.org/msg00630.html. > Logical namespace handling user-defined functions > ------------------------------------------------- > > Key: SYSTEMML-2232 > URL: https://issues.apache.org/jira/browse/SYSTEMML-2232 > Project: SystemML > Issue Type: Task > Reporter: Matthias Boehm > Priority: Major > > At script level functions might have logical namespace names such as {{foo::bar()}}, where foo is the namespace name, and bar is the function name. To handle namespace conflicts, SYSTEMML-631 internally replaced the logical namespaces with filenames. For reasons such as improved statistics output and the handling of namespace functions in the recently introduced {{eval}} function (SYSTEMML-2077), it would be good to keep the logical namespace as well. > This task aims to (1) extend the {{FunctionStatementBlock}} and {{FunctionProgramBlock}} data structures to keep the logical namespace name, (2) extend the parser and compiler accordingly, and (3) modify the statistics maintenance to use the function key (i.e., concatenation of logical namespace and function name) as the opcode. -- This message was sent by Atlassian JIRA (v7.6.3#76005)