systemml-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daiki Matsunaga (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SYSTEMML-2233) Cleanup redundant error message logging
Date Wed, 04 Apr 2018 06:09:00 GMT

    [ https://issues.apache.org/jira/browse/SYSTEMML-2233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425062#comment-16425062
] 

Daiki Matsunaga commented on SYSTEMML-2233:
-------------------------------------------

[~mboehm7] Thank you for creating these issues! I'll try this one first as you've suggested.
It might take some time just to get used to the development process and the code but I will
comment again if something comes up or when I think I've fixed it.

> Cleanup redundant error message logging
> ---------------------------------------
>
>                 Key: SYSTEMML-2233
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-2233
>             Project: SystemML
>          Issue Type: Task
>            Reporter: Matthias Boehm
>            Priority: Major
>
> This task aims to cleanup redundant and thus unnecessary error logging in the package
{{org.apache.sysml.parser}}. Specifically, there are many instances where the same (copied)
error message is logged via {{LOG.error}} and thrown as an exception, which eventually ends
up in the log as well. We should delete the redundant logging via {{LOG.error}} for all instances
that are immediately followed by a thrown exception. As a byproduct this cleanup also increases
maintainability because these redundant messages would otherwise require consistent updates.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message