systemml-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nakul Jindal (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (SYSTEMML-1806) setTextValue in DMLConfig is not behaving correctly
Date Wed, 26 Jul 2017 21:26:00 GMT

     [ https://issues.apache.org/jira/browse/SYSTEMML-1806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Nakul Jindal closed SYSTEMML-1806.
----------------------------------
    Resolution: Fixed

Fixed by commit https://github.com/apache/systemml/commit/3fd8e495e26ba70eed22bf16c51a7bf69474c1c3

> setTextValue in DMLConfig is not behaving correctly
> ---------------------------------------------------
>
>                 Key: SYSTEMML-1806
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-1806
>             Project: SystemML
>          Issue Type: Bug
>          Components: Runtime
>            Reporter: Nakul Jindal
>            Assignee: Nakul Jindal
>             Fix For: SystemML 1.0
>
>
> The problem was discovered when trying to set a configuration property from MLContext.
> Specifically, it was to try and restrict which GPU to use for the program. Currently
this is done via a System property.
> This was the script:
> {code}
> unet = Caffe2DML(spark, solver='solver.prototxt', input_shape=img_shape)
> unet.setGPU(True)
> unet.setForceGPU(True)
> unet.setConfigProperty("systemml.stats.extraGPU", "true")
> unet.setConfigProperty("systemml.gpu.availableGPUs", "1")
> {code}
> Here is what I discovered:
> The first time [setText|https://github.com/apache/systemml/blob/master/src/main/java/org/apache/sysml/conf/DMLConfig.java#L266]
value is called on an empty DMLConfig (by calling new DMLConfig()) as opposed to by parsing
a file, a new _xmlRoot is initialized.
> Thereafter, since the _xmlRoot is not null, it tries to call getElementsByTagName, even
when the tag is different. In the example above, the tag is {{systemml.stats.extraGPU"}} the
first time around and {{systemml.gpu.availableGPUs}} the second time around.
> The bug is in [setText|https://github.com/apache/systemml/blob/master/src/main/java/org/apache/sysml/conf/DMLConfig.java#L253]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message