systemml-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matthias Boehm (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SYSTEMML-1740) Missing call to super in FunctionOp#computeMemEstimate()
Date Thu, 06 Jul 2017 00:36:00 GMT

    [ https://issues.apache.org/jira/browse/SYSTEMML-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075690#comment-16075690
] 

Matthias Boehm commented on SYSTEMML-1740:
------------------------------------------

Thanks for bringing this up [~tedyu]. The reason why FunctionOps do not call {{super.computeMemEstimate()}}
is that function calls (for example of DML-bodied functions) use "call-by-reference" for inputs
and hence do not need to pin their inputs or outputs, and hence do not require memory. Accordingly,
we handle these memory estimates in a function type specific manner. 

> Missing call to super in FunctionOp#computeMemEstimate()
> --------------------------------------------------------
>
>                 Key: SYSTEMML-1740
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-1740
>             Project: SystemML
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> super.computeMemEstimate() should be called, as is done in other classes such as AggBinaryOp.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message