systemml-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brendan Dwyer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SYSTEMML-1406) Fix whitespace issues in main algorithms
Date Tue, 02 May 2017 23:41:04 GMT

    [ https://issues.apache.org/jira/browse/SYSTEMML-1406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994029#comment-15994029
] 

Brendan Dwyer commented on SYSTEMML-1406:
-----------------------------------------

Since DML is supposed to look like R you may want to refer to the [Google R style guide|https://google.github.io/styleguide/Rguide.xml].
They recommend using spaces instead of tabs.

> Fix whitespace issues in main algorithms
> ----------------------------------------
>
>                 Key: SYSTEMML-1406
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-1406
>             Project: SystemML
>          Issue Type: Improvement
>          Components: Algorithms
>            Reporter: Deron Eriksson
>            Assignee: Deron Eriksson
>
> 1) The main algorithms in scripts/algorithms use both spaces and tabs, which can lead
to readability issues when looking at the scripts in an environment such as GitHub. See https://github.com/apache/incubator-systemml/tree/master/scripts/algorithms.
We should convert tabs to spaces and format accordingly to improve script readability.
> 2) Remove trailing whitespace since git does not like it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message