systemml-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Deron Eriksson (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (SYSTEMML-137) Standard format needs to be applied to all Java files
Date Fri, 19 May 2017 01:24:05 GMT

     [ https://issues.apache.org/jira/browse/SYSTEMML-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Deron Eriksson resolved SYSTEMML-137.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: SystemML 1.0

[PR505|https://github.com/apache/incubator-systemml/pull/505] adds a standard Java formatting
profile to the project, so I will close this JIRA.

I imagine this format will probably be applied to our Java files over time to add consistency.

> Standard format needs to be applied to all Java files
> -----------------------------------------------------
>
>                 Key: SYSTEMML-137
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-137
>             Project: SystemML
>          Issue Type: Task
>            Reporter: Deron Eriksson
>            Assignee: Deron Eriksson
>            Priority: Critical
>             Fix For: SystemML 1.0
>
>
> A standard code format template (such as those used in Eclipse and IntelliJ) setting
things such as code line widths, comment line widths, and styles of angle brackets (typical
C style vs typical Java style) needs to be applied to ALL java files. It's very important
that all Java files follow the same standard code formatting. This is especially critical
for doing tasks such as file version comparisons. If people apply different code formats,
it basically becomes impossible to do file version comparisons across the code format change.
> Therefore, we need to pick a standard code format template and apply this format to all
Java files.
> Everyone working on SystemML should then utilize the same standard code format. Pull
requests that don't follow the standard code format should be rejected since it makes file
version comparisons difficult or impossible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message