systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [systemml] prithvirajsen commented on issue #729: [DOC] Factorization Machines core module
Date Wed, 13 Mar 2019 20:26:12 GMT
prithvirajsen commented on issue #729: [DOC] Factorization Machines core module
URL: https://github.com/apache/systemml/pull/729#issuecomment-472591448
 
 
   Well, if the goal is simply to add an fm layer, then I guess its fine (I wasn't suggesting
adding a standalone dml implementation).
   
   I looked for documentation on nn layers and seems like we have very sparse docs. For instance,
I couldn't find any documentation explaining at an intuitive, abstract level what conv2d does.
That's what I was suggesting. For the standalone dml algos we have a pdf file with such info.
   
   So feel free to ignore my previous comment. Seems like the comments in the fm layer's implementation
are supposed to serve as sufficient description.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message