systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [systemml] j143-bot commented on issue #812: Moved ARIMA to staging
Date Wed, 06 Mar 2019 00:44:26 GMT
j143-bot commented on issue #812: Moved ARIMA to staging
URL: https://github.com/apache/systemml/pull/812#issuecomment-469918972
 
 
   Thanks @TobiasSchmidtDE , appreciate that. Also, can we add extensive documentation over
a code or a function - may be like, normally we use the following guidelines:
   1. a description for function ([like this one](https://github.com/apache/systemml/blob/master/scripts/nn/layers/sigmoid.dml#L29))
   2. Can we add the matrix dimensions for input and output. Like,
   ```
   X : Inputs of shape (n, m)
   ``` 
   3. Also, for now only focus on the main script, and send one PR for each script. - So that
anyone can chime in and see what's working & approve.
   
   If any step feels exhaustive or having some runtime errors with calculations let us know.
:)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message