From dev-return-2345-archive-asf-public=cust-asf.ponee.io@systemml.apache.org Thu Mar 1 13:31:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B795F18064D for ; Thu, 1 Mar 2018 13:31:05 +0100 (CET) Received: (qmail 16953 invoked by uid 500); 1 Mar 2018 12:31:04 -0000 Mailing-List: contact dev-help@systemml.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@systemml.apache.org Delivered-To: mailing list dev@systemml.apache.org Received: (qmail 16669 invoked by uid 99); 1 Mar 2018 12:31:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Mar 2018 12:31:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 86F9D1A02DD for ; Thu, 1 Mar 2018 12:31:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.908 X-Spam-Level: * X-Spam-Status: No, score=1.908 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001, T_REMOTE_IMAGE=0.01] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id cP-1XLWmyfsC for ; Thu, 1 Mar 2018 12:31:01 +0000 (UTC) Received: from mail-pl0-f47.google.com (mail-pl0-f47.google.com [209.85.160.47]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 6BCA75F17A for ; Thu, 1 Mar 2018 12:31:00 +0000 (UTC) Received: by mail-pl0-f47.google.com with SMTP id s13-v6so3549246plq.6 for ; Thu, 01 Mar 2018 04:31:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=7zXTBhY3PzU8w0YTFnfl7eMRbAuQpIuUiCXOnCyeFfc=; b=U0IqZGl+tKk3reawdmSn/nQVJEHDm+66PDwnFCfSAO/XdnmpUkom5YJJCX53NHTG/z Zvu0ErZISpgKey+6jqAEhN9hMQOOgmieG2YUBZvFH7GjAtt0FjWNP3F/OgHu+bjwiz6R qlOEeE8xyoBzzF2Kl9J7sF5edrhn/2j5XsqToEreVaWhQc526fMPJ2to15acZ5BqDP/w IMmYcbgJYUGzwOZj8vCIxd9m+cE7rA/wPg82Rjuo5M4jS+55reanPpoVZYDK8Z803i7B LYDPnDUQefs0NKW+aZIGcUKr0+1Iq1POdKabGVcN6CG+LwaczNqgiKbM3fbKqkNAieBo xlrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=7zXTBhY3PzU8w0YTFnfl7eMRbAuQpIuUiCXOnCyeFfc=; b=QBqNMabwR9OTKZfkzS7wjEWsuTtfHPcmT5fa5Nt/BqafRRXNsS2qHGGelVuu4RDPlo SlsKoFSe9r4yJVQYaFp91dmYEZMil3EZfImpBXTrNvQzxqgB9LtcWiAjDro+J97YvT8p fyYyKjMWnAgBESM/eoqZk7UVmOEZS40WABl135oQyVnrPUi92ByMXanEJW+JxxkHht4Y 26GI4L6rzYWwVf92jg9gnH/QfePC9ATZns5IupP04IZMVjsyJSvccKh0wIDHGkjqDCuS 8eU/dH5YCAvdrARVxmeJqROsfYTnMkugzdxAMhbxGBjR6DZgSLxoSz+e3LNTAyF+uPD2 ukEA== X-Gm-Message-State: APf1xPBMPA65xsxYC5NX0YzcF5A4PPk38U0B5nqic26cqB0rOMRDwMf0 glCVAw03CPkvwGSexUds65UJAOILEF88VZ02CWdl/g== X-Google-Smtp-Source: AG47ELtsFKo1uhvkvq9+WP7/+rOm+W7ucXLP54kT7vthX2tIhGQUaoq8Tjn3XEQnh4G+h5a4ezpakZQDRKGPOd0ciJc= X-Received: by 2002:a17:902:243:: with SMTP id 61-v6mr1801528plc.202.1519907458256; Thu, 01 Mar 2018 04:30:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.144.66 with HTTP; Thu, 1 Mar 2018 04:30:57 -0800 (PST) In-Reply-To: References: From: Chamath Abeysinghe Date: Thu, 1 Mar 2018 18:00:57 +0530 Message-ID: Subject: Re: Extending Codegen algorithm tests for heuristics To: dev@systemml.apache.org, Matthias Boehm Content-Type: multipart/alternative; boundary="00000000000024125a05665908f2" --00000000000024125a05665908f2 Content-Type: text/plain; charset="UTF-8" Thanks for your detailed reply. I did some coding [1] for this issue SYSTEMML-2159 to extend test cases for FA & FNR . I got a problem regarding success criteria's, "generating at least one fused operator" condition, I think this means I have to look into stats of Heavy hitter instructions and check if there are any fused operators. (my guess is uamin and uamax are the operators what I have to look for, but I am not sure about this because I don't know the meaning of these instructions). Please help me to clarify this. If my approach is correct I could send a PR after fixing tests for other algorithms. Thanks. Regards, Chamath [1] https://github.com/apache/systemml/compare/master...chamathabeysinghe:SYSTEMML-2159?diff=split&name=SYSTEMML-2159 On Tue, Feb 27, 2018 at 1:54 AM, Matthias Boehm wrote: > ---------- Forwarded message ---------- > From: Matthias Boehm > Date: Mon, Feb 26, 2018 at 11:59 AM > Subject: Re: Extending Codegen algorithm tests for heuristics > To: Chamath Abeysinghe > > > great - thanks for taking this over Chamath. > > In general, I would recommend to use this task to explore SystemML a > little. For example, take one of the codegen algorithm tests from > org.apache.sysml.test.integration.functions.codegenalg (e.g., > AlgorithmL2SVM) and pass different flags such as -stats, -explain, -explain > recompile_hops, -explain recompile_runtime to programArgs and try to > understand the output. If you come over specific questions, please just > ask. > > To answer your detailed questions: > > 1) We recently added a code generation framework that automatically > identifies opportunities for fused operators and subsequently generates > code for these operators. A major part is the selection of fusion plans, > for which we provide heuristics and a cost-based optimizer. By default (and > thus also in our testsuite), we use the cost-based optimizer, but it would > be good regularly test the heuristics as well. > > 2) You can configure the used optimizer in your SystemML-config.xml file as > follows: > fuse_all > Valid alternatives are: fuse_all, fuse_no_redundancy, fuse_cost_based, and > fuse_cost_based_v2 (default). You can provide alternative config xml files > and switch them dynamically via getConfigTemplateFile. > > 3) Similar to the existing tests, it needs to (1) run without errors, (2) > produce correct results as compared to R, and (3) generate at least one > fused operator. > > Regards, > Matthias > > On Mon, Feb 26, 2018 at 6:54 AM, Chamath Abeysinghe < > abeysinghechamath@gmail.com> wrote: > > > Hi All, > > As per the guidelines given to GSoC students, I would like to work on the > > SYSTEMML-2159 [1] issue as a starting point. But I don't understand the > > background of the issue. Can someone help me with understanding the > context > > of this issue? > > > > Few problems I got are, > > > > 1) What are fusion heuristics, fuse-all and fuse-no-redundancy? > > 2) Can I pass those heuristic related configurations as args to execute > > DMLScript? > > 3) What is the success criteria for a test that use those heuristics? > > > > Thank you in advance > > > > Regards, > > Chamath > > > > [1] https://issues.apache.org/jira/browse/SYSTEMML-2159 > > > > -- > > Chamath Abeysinghe > > Department of Computer Science and Engineering > > University of Moratuwa > > [image: > > https://www.linkedin.com/in/kaushalya-gayan-batawala- > bbb5927a?trk=hp-identity-name] > > > > Mobile : +94752930548 > > > -- Chamath Abeysinghe Department of Computer Science and Engineering University of Moratuwa [image: https://www.linkedin.com/in/kaushalya-gayan-batawala-bbb5927a?trk=hp-identity-name] Mobile : +94752930548 --00000000000024125a05665908f2--