Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 383E8200CB6 for ; Thu, 15 Jun 2017 06:04:17 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 36E95160BE8; Thu, 15 Jun 2017 04:04:17 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7D574160BDB for ; Thu, 15 Jun 2017 06:04:16 +0200 (CEST) Received: (qmail 24469 invoked by uid 500); 15 Jun 2017 04:04:15 -0000 Mailing-List: contact dev-help@systemml.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@systemml.apache.org Delivered-To: mailing list dev@systemml.apache.org Received: (qmail 24457 invoked by uid 99); 15 Jun 2017 04:04:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Jun 2017 04:04:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 88753CFDE5 for ; Thu, 15 Jun 2017 04:04:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.149 X-Spam-Level: * X-Spam-Status: No, score=1.149 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-1, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=googlemail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 76NlpN1O9rW1 for ; Thu, 15 Jun 2017 04:04:13 +0000 (UTC) Received: from mail-ua0-f175.google.com (mail-ua0-f175.google.com [209.85.217.175]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id CF0E45F2AC for ; Thu, 15 Jun 2017 04:04:12 +0000 (UTC) Received: by mail-ua0-f175.google.com with SMTP id g40so1574388uaa.3 for ; Wed, 14 Jun 2017 21:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=psuhNbRyL/BBvgjKuitns/McCNBr+SMa3dgjllpfQRc=; b=ZtTuSJ5zHL2/nAeg770uhv7RyeCevmDrjHdHyhd4/hXghoxN1buzQ2tG4HtIOTlHKn k9dyNzEQ3/5x7tA+xmaWxFBGYpbnquP7E1xgvaOHYoHn3GbQYgH7zdDu/TSEjTj5iz8P JOiDYE9Z+hgRPmGrjq2/XZHOpL+uv8Pk7AieVwZvroqe69FaD9kRtBn8cO5hEftMGkUV o/t/3JPFnPI9b8NyfmXYsnVpQsX7vGMekgeS/qBwHRvof7Ni22eihdiKMNf5IabAVxeV qkKeRkpVYf/r+Wh5k313uP8M3iu9fcaaoUuPKadnWNri2gRC+NjhSf/c4SqMhkuUqAR4 RuDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=psuhNbRyL/BBvgjKuitns/McCNBr+SMa3dgjllpfQRc=; b=n25oAK8QXgeLSXMqxj0BCs2c32cmhpLWYHYGq00Z+0iBrZO2l8vpr+CiU0eHzKbUmd Pla8grfSscNOJX/7/g68ElGvfLZMuk5aqLyvM4S1UL+6d1ebNPLPqz2Ja4im2xIqzhef W+7qoaNwyy3Kwm7CfwmGmgH2gR72fazGAG0q8a9fZBApNGbv21cSTZHRVRA1i4Wzypmz O50fDDQ3KAsfGTFsU4sBsQkfbVx18lmiIoEI6PxpFzwxhh2BiBs5ekshTgpf/vxwlvG7 GAqpehP0P/gA2kWZieIDdjAITQpe5J2XDrlZUpcGzv+K3zpnyH0kvcfUk48Nk2Ladao7 fkFA== X-Gm-Message-State: AKS2vOwNBLvfnak5Q5aQ9UtmtiyJeO5l8Yb5C2WYMlZSMiPM8URZuB6U hnP6tMT9LbzmGZcG0U7dqvT89UGd8w== X-Received: by 10.176.86.134 with SMTP id a6mr1949033uab.109.1497499445744; Wed, 14 Jun 2017 21:04:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.176.95.196 with HTTP; Wed, 14 Jun 2017 21:04:05 -0700 (PDT) From: Matthias Boehm Date: Wed, 14 Jun 2017 21:04:05 -0700 Message-ID: Subject: Re: Rework inter-procedural analysis To: dev@systemml.apache.org Content-Type: multipart/alternative; boundary="94eb2c1b040283dc7e0551f7c2be" archived-at: Thu, 15 Jun 2017 04:04:17 -0000 --94eb2c1b040283dc7e0551f7c2be Content-Type: text/plain; charset="UTF-8" sure - I'll try to add some documentation of IPA, probably directly inlined into the code. Unfortunately, a too verbose dev documentation quickly gets outdated because nobody updates it - let's see if we find the sweet spot that works for the project. Regards, Matthias On Wed, Jun 14, 2017 at 4:15 PM, wrote: > Agreed. More documentation, especially within the optimizer portion of > the engine, is quite useful. Given that a large number of our bugs and > performance issues stem from this area, it would be good for it to be clean > and well documented so that future bug searches/fixes can be completed in a > more expedient manner. > > -- > > Mike Dusenberry > GitHub: github.com/dusenberrymw > LinkedIn: linkedin.com/in/mikedusenberry > > Sent from my iPhone. > > > > On Jun 14, 2017, at 8:51 AM, Nakul Jindal wrote: > > > > Hi Matthias, > > > > If its not too much trouble, could you please create a design document > for > > this change. > > This will help the rest of the contributors work on this component as > well. > > > > Thanks, > > Nakul > > > > > > On Wed, Jun 14, 2017 at 12:00 AM, Matthias Boehm > > > wrote: > > > >> just a quick heads up: in the next couple of days, I'll rework our > existing > >> inter-procedural analysis (IPA) in order to (1) create well-defined IPA > >> passes, (2) reuse functional call graphs across multiple rounds of IPA, > and > >> (3) introduce new IPA passes such as fine-grained literal propagation > and > >> replacements as well as inlining of functions with control structures. > This > >> will help improve the performance and debugging of scripts with complex > >> function call patterns. However, since this is a rather disruptive > change, > >> we might experience temporarily some compiler issues - if that happens > >> please file anything you encounter against SYSTEMML-1668. > >> > >> Regards, > >> Matthias > >> > --94eb2c1b040283dc7e0551f7c2be--