Mailing-List: contact dev-help@systemml.incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@systemml.incubator.apache.org
MIME-Version: 1.0
In-Reply-To: <39b71f78-2562-27c0-109b-1ab558d31b69@gmail.com>
Subject: Re: Namespace handling w/ imports
To: dev@systemml.incubator.apache.org
From: "Glenn Weidner" <gweidner@us.ibm.com>
Date: Sun, 12 Feb 2017 22:15:33 -0800
References: <39b71f78-2562-27c0-109b-1ab558d31b69@gmail.com>
Content-type: multipart/related;
	Boundary="0__=8FBB0A55DF8A69048f9e8a93df938690918c8FBB0A55DF8A6904"
Message-Id: <OFAAD36C3F.9491317C-ON002580C6.0019EF94-882580C6.00226237@notes.na.collabserv.com>
archived-at: Mon, 13 Feb 2017 06:15:56 -0000

--0__=8FBB0A55DF8A69048f9e8a93df938690918c8FBB0A55DF8A6904
Content-type: multipart/alternative;
	Boundary="1__=8FBB0A55DF8A69048f9e8a93df938690918c8FBB0A55DF8A6904"


--1__=8FBB0A55DF8A69048f9e8a93df938690918c8FBB0A55DF8A6904
Content-Transfer-Encoding: quoted-printable
Content-type: text/plain; charset=US-ASCII


Use of source filenames instead of default namespace helped address various
issues and tasks under https://issues.apache.org/jira/browse/SYSTEMML-590
that were encountered when creating the SystemML-NN script library.  Unit
tests were also added to cover different import scenarios.  As I recall,
function name conflicts could potentially occur between independent source
files when global default namespace used.  It also helped simplify calling
dml-bodied functions when a file was imported by another.

Thanks,
Glenn


From:	Matthias Boehm <mboehm7@googlemail.com>
To:	dev@systemml.incubator.apache.org
Date:	02/12/2017 12:30 AM
Subject:	Namespace handling w/ imports


While debugging our mnist=5Flenet script, I encountered an issue with our
namespace handling with imports. Here is the related function call graph
(after inlining):

----FUNCTION CALL GRAPH
------MAIN PROGRAM
--------.\mnist=5Flenet.dml::train
----------.\nn/layers/dropout.dml::forward
----------.\mnist=5Flenet.dml::predict

but it should read as follows

----FUNCTION CALL GRAPH
------MAIN PROGRAM
--------.defaultNS::train
----------dropout::forward
----------.defaultNS::predict

The namespace handling was changed a while ago. So my question is: was
there a necessity to encode the filenames in the namespace or is this
just a bug?


Regards,
Matthias


--1__=8FBB0A55DF8A69048f9e8a93df938690918c8FBB0A55DF8A6904
Content-Transfer-Encoding: quoted-printable
Content-type: text/html; charset=US-ASCII
Content-Disposition: inline

<html><body><p>Use of source filenames instead of default namespace helped =
address various issues and tasks under <a href=3D"https://issues.apache.org=
/jira/browse/SYSTEMML-590">https://issues.apache.org/jira/browse/SYSTEMML-5=
90</a> that were encountered when creating the SystemML-NN script library. =
 Unit tests were also added to cover different import scenarios.  As I reca=
ll, function name conflicts could potentially occur between independent sou=
rce files when global default namespace used.  It also helped simplify call=
ing dml-bodied functions when a file was imported by another.<br><br>Thanks=
,<br>Glenn<br><br><br><img width=3D"16" height=3D"16" src=3D"cid:1=5F=5F=3D=
8FBB0A55DF8A69048f9e8a93df938690918c8FB@" border=3D"0" alt=3D"Inactive hide=
 details for Matthias Boehm ---02/12/2017 12:30:35 AM---While debugging our=
 mnist=5Flenet script, I encountered an i"><font color=3D"#424282">Matthias=
 Boehm ---02/12/2017 12:30:35 AM---While debugging our mnist=5Flenet script=
, I encountered an issue with our  namespace handling with imp</font><br><b=
r><font size=3D"2" color=3D"#5F5F5F">From:        </font><font size=3D"2">M=
atthias Boehm &lt;mboehm7@googlemail.com&gt;</font><br><font size=3D"2" col=
or=3D"#5F5F5F">To:        </font><font size=3D"2">dev@systemml.incubator.ap=
ache.org</font><br><font size=3D"2" color=3D"#5F5F5F">Date:        </font><=
font size=3D"2">02/12/2017 12:30 AM</font><br><font size=3D"2" color=3D"#5F=
5F5F">Subject:        </font><font size=3D"2">Namespace handling w/ imports=
</font><br><hr width=3D"100%" size=3D"2" align=3D"left" noshade style=3D"co=
lor:#8091A5; "><br><br><br><tt>While debugging our mnist=5Flenet script, I =
encountered an issue with our <br>namespace handling with imports. Here is =
the related function call graph <br>(after inlining):<br><br>----FUNCTION C=
ALL GRAPH<br>------MAIN PROGRAM<br>--------.\mnist=5Flenet.dml::train<br>--=
--------.\nn/layers/dropout.dml::forward<br>----------.\mnist=5Flenet.dml::=
predict<br><br>but it should read as follows<br><br>----FUNCTION CALL GRAPH=
<br>------MAIN PROGRAM<br>--------.defaultNS::train<br>----------dropout::f=
orward<br>----------.defaultNS::predict<br><br>The namespace handling was c=
hanged a while ago. So my question is: was <br>there a necessity to encode =
the filenames in the namespace or is this <br>just a bug?<br><br><br>Regard=
s,<br>Matthias<br><br></tt><br><br><BR>
</body></html>

--1__=8FBB0A55DF8A69048f9e8a93df938690918c8FBB0A55DF8A6904--


--0__=8FBB0A55DF8A69048f9e8a93df938690918c8FBB0A55DF8A6904--