systemml-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luciano Resende <luckbr1...@gmail.com>
Subject Re: Closing pull requests
Date Mon, 21 Dec 2015 06:23:20 GMT
On Sunday, December 20, 2015, Reynold Xin <rxin@databricks.com> wrote:

> Unfortunately only the PR submitter or the ASF infra team can close them.
>
> You can also push a commit to master and close it by using the "close #xxx"
> message.
>
>
+1, i guess there isn't much more we can do.



>
> On Sun, Dec 13, 2015 at 1:04 PM, Deron Eriksson <deroneriksson@gmail.com
> <javascript:;>>
> wrote:
>
> > Hi Luciano and others,
> >
> > I just merged my first pull request from another user into SystemML.
> > Previously, before pushing to Apache master I've been doing a "commit
> > --amend" to add a "Closes #[PR-NUM]." to the end of the commit message so
> > as to let asfgit close the pull request. However, because of the sync
> > issues from Apache to GitHub (2 of my last 5 commits seemed to hang the
> > propagation), I decided to hold off on the "commit --amend" to try to
> keep
> > things as simple as possible to avoid any kind of sync issue.
> >
> > So, the PR merged cleanly and the update shows up on the SystemML project
> > on GitHub as expected. However, the PR is not closed because asfgit
> didn't
> > close it and I don't have permissions to close it.
> >
> > So, at this stage, does the user close the pull request, or is it
> possible
> > for me to have permissions to close the pull request?
> >
> > Thank you,
> > Deron
> >
>


-- 
Sent from my Mobile device

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message