syncope-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ilgrosso <...@git.apache.org>
Subject [GitHub] syncope pull request #70: [SYNCOPE-1301] fixed
Date Thu, 12 Apr 2018 13:54:54 GMT
Github user ilgrosso commented on a diff in the pull request:

    https://github.com/apache/syncope/pull/70#discussion_r181089640
  
    --- Diff: core/provisioning-java/src/main/java/org/apache/syncope/core/provisioning/java/data/AccessTokenDataBinderImpl.java
---
    @@ -135,11 +135,7 @@
                     accessToken.setAuthorities(authorities);
                 }
     
    -            accessTokenDAO.save(accessToken);
    -        }
    -
    -        if (replaceExisting && existing != null) {
    -            accessTokenDAO.delete(existing);
    +            accessTokenDAO.merge(accessToken);
    --- End diff --
    
    `replaceExisting` is an argument of `AccesstTokenDataBinderImpl#create` that your change
would simply ignore.
    Not good: it must be checked.


---

Mime
View raw message